Skip to content

Conversation

@zzstoatzz
Copy link
Collaborator

summary

upgrades the atproto SDK from the stub version (0.0.1) to the current release (0.0.63) and updates the timeseries example to use the modern API.

changes

  • upgraded atproto from v0.0.1 to v0.0.63 as dev dependency
  • updated imports to use modern atproto API (Client, models from top-level package)
  • added atproto_pds_url setting with automatic https:// prefixing for custom PDS instances
  • fixed ImageUrl media_type inference for Bluesky CDN URLs ending in @jpeg
  • updated ThreadViewPost references to models.AppBskyFeedDefs.ThreadViewPost

testing

  • tested authentication with custom PDS instance
  • verified thread fetching and image analysis works correctly
  • confirmed pydantic-ai serialization warnings are resolved

related

🤖 Generated with Claude Code

- upgrade atproto from v0.0.1 (stub) to v0.0.63 as dev dependency
- update imports to use modern atproto API (Client, models from top-level package)
- add atproto_pds_url setting with automatic https:// prefixing
- fix ImageUrl media_type inference for Bluesky CDN URLs ending in @jpeg
- update ThreadViewPost references to models.AppBskyFeedDefs.ThreadViewPost

fixes compatibility with latest atproto SDK and resolves pydantic-ai serialization warnings

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
Copilot AI review requested due to automatic review settings October 26, 2025 03:41
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the atproto SDK from v0.0.1 to v0.0.63 and updates the timeseries example to use the modern API, including fixes for custom PDS instances and Bluesky CDN URL handling.

  • Updated imports to use modern atproto API (Client, models from top-level package)
  • Added atproto_pds_url setting with automatic https:// prefixing
  • Fixed ImageUrl media_type inference for Bluesky CDN URLs

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +26 to +32
@field_validator("atproto_pds_url")
@classmethod
def ensure_url_protocol(cls, v: str) -> str:
"""Ensure the PDS URL has a protocol"""
if not v.startswith(("http://", "https://")):
return f"https://{v}"
return v
Copy link

Copilot AI Oct 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The field_validator decorator should be placed after the @classmethod decorator when used together. The correct order is @classmethod followed by @field_validator('field_name', mode='before') for Pydantic v2.

Copilot uses AI. Check for mistakes.
Copy link
Collaborator Author

@zzstoatzz zzstoatzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm claude!

@zzstoatzz zzstoatzz merged commit e8e0678 into main Oct 26, 2025
4 checks passed
@zzstoatzz zzstoatzz deleted the update-atproto-sdk branch October 26, 2025 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants