Skip to content

Slackbot: dedupe only the root message; process replies normally #1225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 10, 2025
Merged

Slackbot: dedupe only the root message; process replies normally #1225

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 33 additions & 29 deletions examples/slackbot/src/slackbot/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,36 +149,38 @@ async def handle_message(payload: SlackPayload, db: Database):
return Completed(message="Message too long", name="SKIPPED")

if re.search(BOT_MENTION, user_message) and payload.authorizations:
# Use the root thread timestamp as our idempotency key
# Only gate the root message; replies should not be blocked
is_root_message = event.thread_ts is None
root_ts = thread_ts

# Cross-process acquire; only one handler should proceed
acquired = await try_acquire_thread(db, root_ts)
if not acquired:
status = await get_thread_status(db, root_ts)
if status == "in_progress":
assert event.channel is not None, (
"Event channel is None when posting edit-ignored notice"
)
await post_slack_message(
message=(
"✋ I noticed you edited your original message. "
"I'm already working on your first version — please add any "
"clarifications as new messages in this thread so I don't lose track."
),
channel_id=event.channel,
thread_ts=root_ts,
)
if is_root_message:
# Cross-process acquire; only one handler should proceed for the root
acquired = await try_acquire_thread(db, root_ts)
if not acquired:
status = await get_thread_status(db, root_ts)
if status == "in_progress":
assert event.channel is not None, (
"Event channel is None when posting edit-ignored notice"
)
await post_slack_message(
message=(
"✋ I noticed you edited your original message. "
"I'm already working on your first version — please add any "
"clarifications as new messages in this thread so I don't lose track."
),
channel_id=event.channel,
thread_ts=root_ts,
)
return Completed(
message="Ignored edit while in progress",
name="IGNORED_EDIT",
data=dict(thread_ts=root_ts),
)
return Completed(
message="Ignored edit while in progress",
name="IGNORED_EDIT",
message="Duplicate root event after completion",
name="SKIPPED_DUPLICATE",
data=dict(thread_ts=root_ts),
)
return Completed(
message="Duplicate event after completion",
name="SKIPPED_DUPLICATE",
data=dict(thread_ts=root_ts),
)

# Check if this is the designated channel
team_id = payload.team_id or ""
Expand Down Expand Up @@ -261,10 +263,12 @@ async def handle_message(payload: SlackPayload, db: Database):
data=dict(error=str(e), user_context=user_context),
)
finally:
try:
await mark_thread_completed(db, root_ts)
except Exception:
logger.warning("Failed to mark thread as completed")
# Only mark completion for the root message; do not block replies
if "is_root_message" in locals() and is_root_message:
Copy link

Copilot AI Sep 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using 'is_root_message' in locals() is fragile and could break if the variable declaration is moved. Consider restructuring the code to avoid this check, perhaps by moving the completion logic inside the if is_root_message: block or using a different approach to track whether completion is needed.

Copilot uses AI. Check for mistakes.
try:
await mark_thread_completed(db, root_ts)
except Exception:
logger.warning("Failed to mark thread as completed")

return Completed(
message="Responded to mention",
Expand Down
Loading