fix tpuf import #1190
Merged
fix tpuf import #1190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an import error by updating the import path for the NotFoundError exception from the turbopuffer library. The change corrects the import statement to use the root module path instead of a nested error module path.
- Updated turbopuffer NotFoundError import path from
turbopuffer.errortoturbopuffer
| from pydantic_ai.settings import ModelSettings | ||
| from raggy.vectorstores.tpuf import TurboPuffer, query_namespace | ||
| from turbopuffer.error import NotFoundError | ||
| from turbopuffer import NotFoundError |
There was a problem hiding this comment.
The import change from 'turbopuffer.error.NotFoundError' to 'turbopuffer.NotFoundError' suggests a potential API breaking change in the turbopuffer library. Consider verifying this is the correct import path for the version of turbopuffer being used and update any version constraints in requirements if needed.
Suggested change
| from turbopuffer import NotFoundError | |
| from turbopuffer.error import NotFoundError |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.