Skip to content

Conversation

@zzstoatzz
Copy link
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings June 23, 2025 17:03
@zzstoatzz zzstoatzz changed the title scourge avoid bad marvin recommendations Jun 23, 2025
@zzstoatzz zzstoatzz merged commit d452dbb into main Jun 23, 2025
3 checks passed
@zzstoatzz zzstoatzz deleted the bot-prompts branch June 23, 2025 17:04
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enriches the Slackbot’s Prefect guidance by adding explicit “never-use” warnings for deprecated 3.x features and standardizing deployment patterns across three modules.

  • Added “critical” tips for removed Prefect 3.x features in search.py
  • Inserted version‐specific rules into the create_research_agent prompt
  • Updated the system prompt in core.py to include removed/deprecated features guidance

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
examples/slackbot/src/slackbot/search.py Expanded review_common_3x_gotchas() with CRITICAL tips
examples/slackbot/src/slackbot/research_agent.py Added a “CRITICAL VERSION-SPECIFIC RULES” block to the agent prompt
examples/slackbot/src/slackbot/core.py Extended the default system prompt to cover removed/deprecated features
Comments suppressed due to low confidence (4)

examples/slackbot/src/slackbot/search.py:54

  • [nitpick] Wrap the code snippet flow.from_source('https://github.com/owner/repo').deploy('deployment-name') in backticks to clearly distinguish it as code.
        "CORRECT 3.x deployment pattern: flow.from_source('https://github.com/owner/repo').deploy('deployment-name')",

examples/slackbot/src/slackbot/search.py:65

  • [nitpick] Wrap build_from_flow in backticks for consistency and clarity, and consider rephrasing to maintain parallel structure with other tips.
        "If user is on 2.x and asking about deployments, recommend upgrading to 3.x or using workers instead of build_from_flow",

examples/slackbot/src/slackbot/research_agent.py:60

  • Indent this line (and subsequent bullet items) to match the surrounding docstring text block for proper alignment and readability.
CRITICAL VERSION-SPECIFIC RULES:

examples/slackbot/src/slackbot/core.py:57

  • [nitpick] Prefix this instruction with a - to maintain consistency with the surrounding bullet list format.
If a user explicitly mentions using Prefect 2.x, that's fine, but recommend upgrading to 3.x or using workers in 2.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants