Skip to content

Conversation

@zzstoatzz
Copy link
Collaborator

Copilot AI review requested due to automatic review settings June 9, 2025 17:20
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR replaces the local inlined implementations of module tree exploration and signature display with the officially maintained pretty-mod package.

  • Replaces local ModuleTreeExplorer and display_signature with versions from pretty-mod
  • Removes the deprecated local modules.py file
  • Updates pyproject.toml to declare the pretty-mod dependency

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

File Description
examples/slackbot/src/slackbot/search.py Updated import and instantiation to use pretty_mod’s ModuleTreeExplorer
examples/slackbot/src/slackbot/research_agent.py Updated import to use pretty_mod’s display_signature instead of the local version
examples/slackbot/src/slackbot/modules.py Removed the local implementation of ModuleTreeExplorer and display_signature
examples/slackbot/pyproject.toml Added the pretty-mod dependency to support the new implementation
Comments suppressed due to low confidence (3)

examples/slackbot/src/slackbot/search.py:101

  • [nitpick] Check that the named parameter 'max_depth' matches the interface expected by the pretty_mod ModuleTreeExplorer, as its signature may differ from the previous implementation.
explorer = ModuleTreeExplorer(module_path, max_depth=max_depth)

examples/slackbot/src/slackbot/research_agent.py:5

  • [nitpick] Verify that the pretty_mod display_signature function behaves as expected compared to the local implementation it replaces.
from pretty_mod import display_signature

examples/slackbot/src/slackbot/modules.py:1

  • The entire modules.py file has been removed; please confirm that no lingering references to its functions remain in the codebase.
import importlib

"prefect @ git+https://github.com/PrefectHQ/prefect.git@fix-nested-add-metadata",
"numpy",
"raggy[tpuf] @ git+https://github.com/zzstoatzz/raggy.git",
"pretty-mod",
Copy link

Copilot AI Jun 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider pinning the version of pretty-mod to avoid potential compatibility issues in the future.

Suggested change
"pretty-mod",
"pretty-mod>=1.2.0,<2.0.0",

Copilot uses AI. Check for mistakes.
@zzstoatzz zzstoatzz merged commit d8b3f99 into main Jun 9, 2025
3 checks passed
@zzstoatzz zzstoatzz deleted the pretty-mod branch June 9, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants