fastmcp adapter #1141
Merged
fastmcp adapter #1141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces FastMCP integration into marvin by adding a new beta adapter for FastMCP servers and updating the Agent class to perform runtime conversion of MCP server instances. Key changes include modifications to the Agent’s mcp_servers field and get_mcp_servers method, implementation of a FastMCP adapter in the integrations module, and corresponding updates to dependencies, examples, and documentation.
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/marvin/beta/init.py | Exposes the FastMCP adapter (MCPServerStreamHTTP) as part of the beta public API. |
| src/marvin/agents/agent.py | Updates the mcp_servers field type and conversion logic to support FastMCP servers. |
| src/marvin/_internal/integrations/mcp.py | Removes a circular dependency import for cleaner type-checking. |
| src/marvin/_internal/integrations/fastmcp.py | Implements the FastMCP adapter and conversion function for integration support. |
| pyproject.toml | Adds fastmcp as a dependency and removes the examples workspace entry. |
| examples/fastmcp/hello.py | Provides an example usage of FastMCP within the marvin framework. |
| docs/docs.json, docs/api-reference/*.mdx | Updates documentation to include the new beta module and API references. |
github-actions
bot
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.