fix: add proxy timeouts and modernize networking in apps dev#3741
fix: add proxy timeouts and modernize networking in apps dev#3741jlowin merged 6 commits intoPrefectHQ:mainfrom
Conversation
marvin-context-protocol
bot
added
bug
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 40a214113d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d37ab6e225
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
jlowin
left a comment
jlowin
left a comment
There was a problem hiding this comment.
Looks good — proxy timeout is a nice improvement, and the httpx migration is clean.
2 participants
Description
This PR improves the stability and security of the
fastmcp dev appsserver by addressing potential resource hangs and modernizing network calls:httpx.AsyncClientin theproxy_mcphandler. Previously, it usedtimeout=None, which could cause the dev server to hang indefinitely if the backend MCP server was unresponsive.urllib.request.urlopenwithhttpx.Clientfor fetching SDK assets from NPM and esm.sh. This ensures consistency with the project's preferred HTTP library and provides better handling of redirects and connection pooling.Closes #
Contribution type
Checklist
uv run prek run --all-filesand all checks pass