[Do not merge] Fix FileSystemProvider reload race condition, redundant reloads, and missing warning#3660
Open
[Do not merge] Fix FileSystemProvider reload race condition, redundant reloads, and missing warning#3660
Conversation
…missing warning Co-authored-by: Bill Easton <strawgate@users.noreply.github.com> 🤖 Generated with Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reload path in
FileSystemProviderhad two correctness issues and a usability gap. The component dict was cleared and rebuilt in place, so a concurrent reader could see an empty dict mid-reload. Every concurrent request also triggered its own full directory scan because the lock serialized but didn’t deduplicate. And a typo in the root path silently produced zero components.Now
_load_componentsbuilds into a fresh dict and swaps the reference atomically, a generation counter lets waiters skip redundant reloads, and a non-existent root logs a warning.Closes #3625 (bugs 4, 5, and missing warning)
Generated with Claude Code