This repository was archived by the owner on Apr 24, 2020. It is now read-only.
[Bugfix] Fix substring replacements used for trimming #1376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the first (always leading) substring matching the home path instead of removing all occurrences of it from the absolute path.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the first (always leading) substring matching the home path
instead of removing all occurrences of it from the absolute path.
Examples of issues being solved by this PR:
/home/user/hack/universityis currently shortened as~/niversityinstead of~/h/univeritywith the strategytruncate_to_unique/home/user/dir0/dir1~/dir2is currently shortened as~/../dir1dir2instead of~/../../dir2with the strategytruncate_to_first_and_last