Default filters with tests#2076
Merged
Merged
Conversation
Contributor
Author
|
@luanfreitasdev Hey it is me (johannesMEGABAD) I somehow can not do anything on the other PR anymore... therefore I created a new one from my private account. I also provided the tests directly in this PR. They are in a single file. I hope that's ok. I also implemented your suggestion in the applyDefaultFilter function. The tests did pass on my machine. |
Member
|
Hi @h4or , thank you again! |
7 tasks
non ?? check on filled() for $columnsByField; Using data_get for filter key instead of direct access
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
⚡ PowerGrid - Pull Request
Description
This PR completes #2054 which can be closed.
Related Issue(s):
Documentation
This PR requires Documentation update?