Conversation
robbie-c
force-pushed
the
add-pr-ci-checks
branch
from
15b8452 to
092127b
Compare
| let client = crate::client(env!("POSTHOG_API_KEY")); | ||
| use std::collections::HashMap; | ||
|
|
||
| let api_key = std::env::var("POSTHOG_RS_E2E_TEST_API_KEY").unwrap(); |
Member
There was a problem hiding this comment.
Can you add an .env.example file to make it clear that we need this to run tests locally? You could also add a section to the README.md explaining that one needs to grab an API key from their instance to be able to run tests
rafaeelaudibert
approved these changes
Jan 6, 2025
Member
rafaeelaudibert
left a comment
rafaeelaudibert
left a comment
There was a problem hiding this comment.
Approving so that this can be merged once CI passes, lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't have the admin powers to set up the POSTHOG_RS_E2E_TEST_API_KEY environment variable, but when that's done this can be merged :)
Obviously there's a lot more we could do here - but I wanted to get the existing test working on CI, and a test for my previous PR