Skip to content

MESH-2274\Remove CDD check for transferring#1822

Merged
Neopallium merged 1 commit intodevelopfrom
MESH-2274
May 5, 2025
Merged

MESH-2274\Remove CDD check for transferring#1822
Neopallium merged 1 commit intodevelopfrom
MESH-2274

Conversation

@HenriqueNogara
Copy link
Copy Markdown
Contributor

changelog

other

  • Removes CDD check for transferring;

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the CDD check for transferring funds by eliminating the safe_transfer_core function and updating its references. Key changes include:

  • Updating treasury_test.rs to reflect new balance expectations.
  • Replacing calls to safe_transfer_core with transfer_core in balances implementation.
  • Removing the safe_transfer_core function and associated documentation.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
pallets/runtime/tests/src/treasury_test.rs Updated test assertions to align with the new transfer behavior
pallets/balances/src/lib.rs Removed safe_transfer_core and updated transfer calls to use transfer_core
Comments suppressed due to low confidence (1)

pallets/balances/src/lib.rs:483

  • [nitpick] Verify that related documentation and any error handling around CDD checks are updated to match the change, since safe_transfer_core has been removed in favor of direct calls to transfer_core.
Self::transfer_core(

@Neopallium Neopallium merged commit d0e194c into develop May 5, 2025
17 checks passed
@Neopallium Neopallium deleted the MESH-2274 branch May 5, 2025 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants