Remove From Storage; Add Extrinsic; Remove Check#1786
Merged
Conversation
Neopallium
reviewed
Jan 22, 2025
Contributor
Neopallium
left a comment
Neopallium
left a comment
There was a problem hiding this comment.
Looks good, but there is some duplicate code that can be removed.
HenriqueNogara
changed the title
Neopallium
approved these changes
Jan 23, 2025
Neopallium
force-pushed
the
frame_v2_upgrade_part7
branch
from
90f202f to
f5bc1c0
Compare
Base automatically changed from
frame_v2_upgrade_part7
to
frame_v2_upgrade_part6
January 29, 2025 08:07
Base automatically changed from
frame_v2_upgrade_part6
to
frame_v2_upgrade_part5
January 29, 2025 08:08
Base automatically changed from
frame_v2_upgrade_part5
to
frame_v2_upgrade_part4
January 29, 2025 08:09
Base automatically changed from
frame_v2_upgrade_part4
to
frame_v2_upgrade_part3
January 29, 2025 08:09
Base automatically changed from
frame_v2_upgrade_part3
to
frame_v2_upgrade_part2
January 29, 2025 08:10
HenriqueNogara
force-pushed
the
small-issues
branch
from
21641b8 to
f305464
Compare
Neopallium
approved these changes
Feb 5, 2025
…zero; Remove portfolio custody check when creating an asset
HenriqueNogara
force-pushed
the
small-issues
branch
from
f305464 to
3f64cf4
Compare
Neopallium
approved these changes
Feb 10, 2025
adamdossa
approved these changes
Feb 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MESH-2135, MESH-2248, MESH-1951
changelog
new external API
update_global_metadata_specextrinsic;new events
GlobalMetadataSpecUpdatedevent;other
custody_and_permissioncheck when creating an asset;