Skip to content

Frame v2 upgrade part3#1773

Merged
Neopallium merged 2 commits intoframe_v2_upgrade_part2from
frame_v2_upgrade_part3
Jan 29, 2025
Merged

Frame v2 upgrade part3#1773
Neopallium merged 2 commits intoframe_v2_upgrade_part2from
frame_v2_upgrade_part3

Conversation

@Neopallium
Copy link
Copy Markdown
Contributor

@Neopallium Neopallium commented Dec 19, 2024

FRAME v1 -> v2:

  1. Update Base pallet.
  2. Update Bridge pallet.
  3. Update Permissions pallet.
  4. Update Treasury pallet.
  5. Update Sto pallet.
  6. Update Group pallet.

For all pallets:

  1. Add the try-runtime feature to the pallet Cargo.toml, this is needed for FRAME v2 pallets.
  2. The old FRAME v1 decl_module macro also defines type Pallet which is the same as Module. In FRAME v2 Module is deprecated, so I changed all references to all pallets to use Pallet instead of Module. This will make upgrading the other pallets easier.

CI Pipeline changes:
Use a chain spec snapshot of v7.0.0 (from the ci-runtime build) to start the dev chain used in the Rust integration tests. Then run the integration tests again that older version before upgrading it to the current version built in the PR before running the tests again.

changelog

new features

  • Support loading a custom chain spec for dev and testnet runtimes, by using dev:<spec.json> or testnet:<spec.json> with the --chain option.

@Neopallium Neopallium changed the base branch from develop to frame_v2_upgrade_part2 December 19, 2024 20:49
@Neopallium Neopallium force-pushed the frame_v2_upgrade_part3 branch from 5023104 to 45f613c Compare December 20, 2024 12:08
@Neopallium Neopallium force-pushed the frame_v2_upgrade_part3 branch from 690303d to fe791f0 Compare December 20, 2024 21:28
@Neopallium Neopallium force-pushed the frame_v2_upgrade_part2 branch from f00038f to 9f696f6 Compare December 30, 2024 11:29
@Neopallium Neopallium force-pushed the frame_v2_upgrade_part3 branch from fe791f0 to deec5ec Compare December 30, 2024 11:29
@Neopallium Neopallium force-pushed the frame_v2_upgrade_part2 branch from 9f696f6 to 5114790 Compare December 31, 2024 10:07
@Neopallium Neopallium force-pushed the frame_v2_upgrade_part3 branch from deec5ec to 6403141 Compare December 31, 2024 10:22
@Neopallium Neopallium force-pushed the frame_v2_upgrade_part2 branch from 5114790 to 8c09228 Compare December 31, 2024 10:29
@Neopallium Neopallium force-pushed the frame_v2_upgrade_part3 branch from 6403141 to 50d73c3 Compare December 31, 2024 10:30
@Neopallium Neopallium force-pushed the frame_v2_upgrade_part2 branch from 8c09228 to bebdf7f Compare December 31, 2024 14:19
@Neopallium Neopallium force-pushed the frame_v2_upgrade_part3 branch from 50d73c3 to c632363 Compare December 31, 2024 14:21
@Neopallium Neopallium changed the title [WIP] Frame v2 upgrade part3 Frame v2 upgrade part3 Dec 31, 2024
@Neopallium Neopallium force-pushed the frame_v2_upgrade_part2 branch from bebdf7f to 9b46523 Compare January 14, 2025 10:06
@Neopallium Neopallium force-pushed the frame_v2_upgrade_part3 branch from c632363 to 2a4148e Compare January 14, 2025 10:07
@Neopallium Neopallium force-pushed the frame_v2_upgrade_part2 branch from 9b46523 to c031047 Compare January 14, 2025 14:21
@Neopallium Neopallium force-pushed the frame_v2_upgrade_part3 branch from 2a4148e to fda6237 Compare January 14, 2025 14:21
@Neopallium Neopallium force-pushed the frame_v2_upgrade_part2 branch from c031047 to 4fba416 Compare January 14, 2025 15:46
@Neopallium Neopallium force-pushed the frame_v2_upgrade_part3 branch from fda6237 to d4f3df6 Compare January 14, 2025 15:46
@Neopallium Neopallium force-pushed the frame_v2_upgrade_part3 branch from 23dcb3b to 1de9718 Compare January 15, 2025 16:52
@Neopallium Neopallium force-pushed the frame_v2_upgrade_part2 branch from 4fba416 to 6e846c1 Compare January 16, 2025 17:18
@Neopallium Neopallium force-pushed the frame_v2_upgrade_part3 branch from bb847e0 to 8023a64 Compare January 16, 2025 17:26
@Neopallium Neopallium force-pushed the frame_v2_upgrade_part2 branch from 6e846c1 to 3260e83 Compare January 24, 2025 15:43
Add 'try-runtime' feature to all pallets.

Update Base pallet.

Update Bridge pallet.

Update Permissions pallet.

Update Treasury pallet.

Upgrade Group pallet.

Use 'Pallet' instead of 'Module' for FRAME v1 pallets too.

Add Frame v2 migration helper.

Support loading chain spec with dev/testnet runtime.

Add v7.0 chain spec for ci-runtime.
Add CLI tool to upgrade the ci-chain.
Run the integration tests before and after a chain upgrade.
Bump Rust integration resource class.

Update check_storage_version script for new Frame v2 version.
@Neopallium Neopallium force-pushed the frame_v2_upgrade_part3 branch from 8023a64 to 933523d Compare January 24, 2025 15:43
Update External Agents pallet.

Update Corporate Actions pallet.

Update Capital Distribution pallet.

Update Corporate Ballot pallet.

Update Committee pallet.

Update PolymeshContracts pallet.

Update NFT pallet.

Updated Balances pallet.

Update ComplianceManager pallet.

Cargo fmt

Update Asset pallet.

Update Checkpoint pallet.

Update Statistics pallet. (#1779)

Update Portfolio pallet.

Update Settlement pallet.

Update Identity pallet.
@Neopallium Neopallium merged commit f734044 into frame_v2_upgrade_part2 Jan 29, 2025
@Neopallium Neopallium deleted the frame_v2_upgrade_part3 branch January 29, 2025 08:10
Neopallium added a commit that referenced this pull request Feb 6, 2025
* Fix issue with missing assimilate_storage on Sudo GenesisConfig.

Use workspace deps.

Copy Sudo pallet code from Substrate monthly 2023-03.

cargo fmt Sudo code.

Readd the MIN_WEIGHT support to Sudo.

Update Relayer pallet.

Updated ProtocolFee pallet.

Add missing Rust docs and other cleanup.

Fixup Relayer

Fixup Protocol Fee pallet.

* Frame v2 upgrade part3 (#1773)

Update Sto pallet.

Add 'try-runtime' feature to all pallets.

Update Base pallet.

Update Bridge pallet.

Update Permissions pallet.

Update Treasury pallet.

Upgrade Group pallet.

Use 'Pallet' instead of 'Module' for FRAME v1 pallets too.

Add Frame v2 migration helper.

Support loading chain spec with dev/testnet runtime.

Add v7.0 chain spec for ci-runtime.
Add CLI tool to upgrade the ci-chain.
Run the integration tests before and after a chain upgrade.
Bump Rust integration resource class.

Update check_storage_version script for new Frame v2 version.

Update External Agents pallet.

Update Corporate Actions pallet.

Update Capital Distribution pallet.

Update Corporate Ballot pallet.

Update Committee pallet.

Update PolymeshContracts pallet.

Update NFT pallet.

Updated Balances pallet.

Update ComplianceManager pallet.

Cargo fmt

Update Asset pallet.

Update Checkpoint pallet.

Update Statistics pallet. (#1779)

Update Portfolio pallet.

Update Settlement pallet.

Update Identity pallet.

* Pips docs (#1781)

* Improve docs - part 1

* Improve extrinsic documentation

* Add bound to pips (#1784)

* Solve merge conflicts - import path

* Improve insert_live_queue function

* Add unit test; Improve weight calculation (return max between refunds and votes)

* Prune and refund only on_idle

* Remove const and error

---------

Co-authored-by: Henrique Nogara <nogara.henrique@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants