Skip to content

Frame v2 upgrade part1#1771

Merged
Neopallium merged 45 commits intodevelopfrom
frame_v2_upgrade_part1
Jan 16, 2025
Merged

Frame v2 upgrade part1#1771
Neopallium merged 45 commits intodevelopfrom
frame_v2_upgrade_part1

Conversation

@Neopallium
Copy link
Copy Markdown
Contributor

@Neopallium Neopallium commented Dec 17, 2024

This PR tries to de-tangle the pallet dependencies by moving code out of the pallets/common crate (polymesh-common-utilities).

The common crate has the follow:

  1. Common types. These should be moved to our polymesh-primitives crate.
  2. Custom traits we use to do "soft" linking between our pallets (like the PortfolioSubTrait).
  3. Helper functions like with_transaction. Should be moved to our polymesh-primitives crate.
  4. Benchmark helpers (like UserBuilder). This depends a lot on our Identity pallet, so maybe move it there.
  5. Common constants (like the SystematicIssuers and genesis DIDs). Moved to polymesh-primitives.

Changes:

  1. Move common constants and types from polymesh-common-utilities to polymesh-primitives.
  2. Move WeightInfo, Config and decl_event types from polymesh-common-utilities into the pallet that they belong to.

@Neopallium Neopallium force-pushed the frame_v2_upgrade_part1 branch 2 times, most recently from 8f3ee77 to 0006fff Compare December 18, 2024 14:57
Base automatically changed from remove_old_v7_migrations to develop December 19, 2024 12:33
@adamdossa adamdossa changed the title [WIP] Frame v2 upgrade part1 Frame v2 upgrade part1 Dec 19, 2024
@Neopallium Neopallium force-pushed the frame_v2_upgrade_part1 branch from 1a5a223 to 5a3c14b Compare December 19, 2024 15:43
@Neopallium Neopallium changed the base branch from develop to asset-ticker-migration December 19, 2024 15:43
Base automatically changed from asset-ticker-migration to develop December 27, 2024 12:21
@Neopallium Neopallium force-pushed the frame_v2_upgrade_part1 branch 2 times, most recently from 7fa260f to f5251ac Compare December 31, 2024 10:02
@Neopallium Neopallium changed the base branch from develop to frame_v2_upgrade_pips December 31, 2024 10:02
@Neopallium Neopallium force-pushed the frame_v2_upgrade_part1 branch 2 times, most recently from 6cbba32 to eb72eac Compare December 31, 2024 14:19
@Neopallium Neopallium changed the base branch from frame_v2_upgrade_pips to MESH-/pips December 31, 2024 14:24
@Neopallium Neopallium force-pushed the frame_v2_upgrade_part1 branch from 4b757d0 to 62a3971 Compare January 14, 2025 15:45
Base automatically changed from MESH-/pips to develop January 16, 2025 16:40
@Neopallium Neopallium force-pushed the frame_v2_upgrade_part1 branch from 62a3971 to 8692879 Compare January 16, 2025 16:42
@Neopallium Neopallium enabled auto-merge (squash) January 16, 2025 16:43
@Neopallium Neopallium merged commit 63af899 into develop Jan 16, 2025
@Neopallium Neopallium deleted the frame_v2_upgrade_part1 branch January 16, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants