Merged
Conversation
8f3ee77 to
0006fff
Compare
1a5a223 to
5a3c14b
Compare
This was referenced Dec 19, 2024
Closed
7fa260f to
f5251ac
Compare
6cbba32 to
eb72eac
Compare
HenriqueNogara
approved these changes
Jan 2, 2025
4b757d0 to
62a3971
Compare
adamdossa
approved these changes
Jan 16, 2025
… Balances pallet.
62a3971 to
8692879
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tries to de-tangle the pallet dependencies by moving code out of the
pallets/commoncrate (polymesh-common-utilities).The common crate has the follow:
polymesh-primitivescrate.PortfolioSubTrait).with_transaction. Should be moved to ourpolymesh-primitivescrate.UserBuilder). This depends a lot on our Identity pallet, so maybe move it there.SystematicIssuersand genesis DIDs). Moved topolymesh-primitives.Changes:
polymesh-common-utilitiestopolymesh-primitives.WeightInfo,Configanddecl_eventtypes frompolymesh-common-utilitiesinto the pallet that they belong to.