MESH-2006 multisig improvements part 3#1693
Merged
adamdossa merged 3 commits intoremove_bridge_part_1from Aug 13, 2024
Merged
Conversation
Neopallium
changed the title
Neopallium
changed the title
Neopallium
force-pushed
the
remove_bridge_part_1
branch
from
f95ec97 to
93be1be
Compare
Neopallium
force-pushed
the
MESH-1955-multisig-improvements-part-3
branch
from
24cf7b7 to
3006db8
Compare
Neopallium
changed the title
Neopallium
force-pushed
the
remove_bridge_part_1
branch
from
93be1be to
95981ab
Compare
Neopallium
force-pushed
the
MESH-1955-multisig-improvements-part-3
branch
from
3006db8 to
eb68781
Compare
HenriqueNogara
approved these changes
Aug 5, 2024
adamdossa
approved these changes
Aug 13, 2024
Neopallium
added a commit
that referenced
this pull request
Aug 13, 2024
* Remove multisig.create_or_approve_proposal extrinsic and multisig.ProposalIds storage. * Prune multisig proposal when it is executed/rejected. * Rename MultiSigTxDone to NextProposalId.
Neopallium
added a commit
that referenced
this pull request
Aug 13, 2024
* Remove Bridge extrinsics, events, errors. Only keep the storage. * MESH-2006 multisig improvements part 3 (#1693) * Remove multisig.create_or_approve_proposal extrinsic and multisig.ProposalIds storage. * Prune multisig proposal when it is executed/rejected. * Rename MultiSigTxDone to NextProposalId.
Neopallium
added a commit
that referenced
this pull request
Aug 14, 2024
* Remove Bridge extrinsics, events, errors. Only keep the storage. * MESH-2006 multisig improvements part 3 (#1693) * Remove multisig.create_or_approve_proposal extrinsic and multisig.ProposalIds storage. * Prune multisig proposal when it is executed/rejected. * Rename MultiSigTxDone to NextProposalId.
Neopallium
added a commit
that referenced
this pull request
Aug 15, 2024
* Remove old _as_identity extrinsics. * Fix multisig benchmarks. * Remove use of Signatory type from MultiSig pallet. * Fix JS integration tests. * Add migration for MultiSig Signatory storage. * Don't use scheduler to execute MS proposals. * Add MultiSig secondary key permissions tests. * Rust integration tests needs more memory. * Remove auto_close flag from MultiSig and always close proposals when they have been rejected. * Fix Rust integration test build. * Rename MultiSigToIdentity to CreatorDid. * Disable CI cache for Rust integration tests. * Don't migrate the Votes storage, it will be cleared. * MESH-2006 multisig improvements part 2 (#1690) * Refactor ProposalDetails and ProposalStatus. * Convert multisig pallet to frame v2. * Refactor Multisig events. * Don't use Concat based hashing on the Proposal in storage map ProposalIds. * Don't use Context::current_identity in multisig pallet. Use the MS's linked DID or it's creator DID. * Fix bridge controller's CreatorDID. * Allow a primary key to use custom permissions when making a multisig a secondary key. * Add tests for 'make_multisig_secondary'. * Support adding/removing multiple MS signers. * Emit one event when adding/removing many signers. * Add execution reentry guard to multisig proposal execution. * Fix benchmark for approve and create_proposal. * Use bounded vec for multisig signers. * Fix multisig unit tests. * Make MaxSigners a constant in the metadata. * Remove bridge part 1 (#1691) * Remove Bridge extrinsics, events, errors. Only keep the storage. * MESH-2006 multisig improvements part 3 (#1693) * Remove multisig.create_or_approve_proposal extrinsic and multisig.ProposalIds storage. * Prune multisig proposal when it is executed/rejected. * Rename MultiSigTxDone to NextProposalId. * MESH-2209 multisig improvements part 4 (#1697) * Rename MS creator to admin and add paying DID support. * Split a long running test into smaller tests. * Restrict the total number of signers on a multisig. * Always use the Multisig's DID for adding new signers. * Multisig nesting is not allowed. * Fix test build. * Allow a multisig to remove it's paying DID to pay their own fees. * Add join identity support to MultiSig. * The approve_join_identity call is paid by the joining DIDs primary key. * Add some missing events. * Use wasm based weights. * Add tests for remove_payer. * Remove use of Context::current_identity (#1698) * Remove use of Context::current_identity * Add some more TODOs. * Remove Context::set_current_identity() calls from unit tests. * Remove some more current_identity from unit tests. * Use controller not stash for Unbonded event. * Fix remove_authorization for unlinked keys. * Use GC_DID in treasury event. * Lint fix. * Finish TODOs. * Remove all Context::current_identity code. * Remove identity CurrentDid storage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changelog
new features
modified external API
Multisig.create_or_approve_proposalMultisig.ProposalIdssince we don't lookup proposal ids from the proposal call.Multisig.MultiSigTxDonetoMultisig.NextProposalId.data migration
MultiSigTxDonetoNextProposalId.