Skip to content

Improve secondary key permissions.#1679

Merged
adamdossa merged 22 commits intodevelopfrom
MESH-1973-improve-permission-storage
Aug 15, 2024
Merged

Improve secondary key permissions.#1679
adamdossa merged 22 commits intodevelopfrom
MESH-1973-improve-permission-storage

Conversation

@Neopallium
Copy link
Copy Markdown
Contributor

@Neopallium Neopallium commented Jun 13, 2024

changelog

new features

  • Split secondary key permissions out of Identity.KeyRecords to allow for more efficient permissions checks.

modified external API

  • Changed Identity.KeyRecords storage type to only hold the key type (primary, secondary, multisig) and the DID/AccountId. Secondary key permissions have been split out into storage Identity.KeyExtrinsicPermissions, Identity.KeyAssetPermissions, and Identity.KeyPortfolioPermissions.
  • Renamed type DispatchableName to ExtrinsicName and change it to wrap a String instead of raw bytes Vec<u8>.
  • Changed PalletName to wrap a String instead of raw bytes Vec<u8>.
  • Changed type PalletPermissions to remove the pallet_name field (pallet name is used as a key the new ExtrinsicPermissions type).
  • The extrinsic permissions in type Permissions has been changed to a new type ExtrinsicPermissions which uses maps instead of sets.
  • Storage value ExternalAgents.GroupPermissions has changed since the extrinsic permissions uses maps instead of sets now.

modified events

  • Any event containing a Permissions value will have changed (the extrinsic permissions are stored as a map instead of a set).

other

  • The return type of identity RPC endpoints get_key_identity_data and get_did_records has changed, since the Permissions type now uses a map instead of a set for extrinsic permissions.

@Neopallium Neopallium force-pushed the MESH-1973-improve-permission-storage branch from 325b35e to e62cb98 Compare June 21, 2024 12:12
@Neopallium Neopallium force-pushed the MESH-1973-improve-permission-storage branch from 379874b to e064a64 Compare July 23, 2024 15:51
@Neopallium Neopallium changed the base branch from develop to MESH-1955-multisig-improvements-part-3 July 23, 2024 15:52
@Neopallium Neopallium force-pushed the MESH-1955-multisig-improvements-part-3 branch 2 times, most recently from 3006db8 to eb68781 Compare July 31, 2024 11:05
@Neopallium Neopallium force-pushed the MESH-1973-improve-permission-storage branch from e064a64 to 43d4f66 Compare July 31, 2024 12:53
@Neopallium Neopallium force-pushed the MESH-1973-improve-permission-storage branch from 43d4f66 to 51d12c5 Compare August 7, 2024 16:43
@Neopallium Neopallium changed the base branch from MESH-1955-multisig-improvements-part-3 to remove_global_current_identity August 7, 2024 16:47
@Neopallium Neopallium changed the title [WIP] Improve secondary key permissions. Improve secondary key permissions. Aug 9, 2024
@Neopallium
Copy link
Copy Markdown
Contributor Author

Migrations will be done in a different PR to be based off PR #1699 to avoid major conflicts.

@Neopallium Neopallium force-pushed the remove_global_current_identity branch from 2fa6880 to 91f95f6 Compare August 13, 2024 14:22
@Neopallium Neopallium force-pushed the MESH-1973-improve-permission-storage branch from ba6e2a9 to 8f1ad6c Compare August 13, 2024 14:47
@Neopallium Neopallium force-pushed the remove_global_current_identity branch from 91f95f6 to 30f2e08 Compare August 14, 2024 14:35
@Neopallium Neopallium force-pushed the MESH-1973-improve-permission-storage branch from b6b1cc9 to 8498963 Compare August 14, 2024 15:53
Base automatically changed from remove_global_current_identity to MESH-2209-multisig-improvements-part-4 August 15, 2024 14:07
Base automatically changed from MESH-2209-multisig-improvements-part-4 to MESH-1955-multisig-improvements August 15, 2024 14:08
Base automatically changed from MESH-1955-multisig-improvements to develop August 15, 2024 14:54
@Neopallium Neopallium force-pushed the MESH-1973-improve-permission-storage branch from 8498963 to de5e9d3 Compare August 15, 2024 14:57
@adamdossa adamdossa merged commit e568106 into develop Aug 15, 2024
@adamdossa adamdossa deleted the MESH-1973-improve-permission-storage branch August 15, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants