Improve secondary key permissions.#1679
Merged
Conversation
325b35e to
e62cb98
Compare
379874b to
e064a64
Compare
3006db8 to
eb68781
Compare
e064a64 to
43d4f66
Compare
43d4f66 to
51d12c5
Compare
Contributor
Author
|
Migrations will be done in a different PR to be based off PR #1699 to avoid major conflicts. |
2fa6880 to
91f95f6
Compare
ba6e2a9 to
8f1ad6c
Compare
91f95f6 to
30f2e08
Compare
b6b1cc9 to
8498963
Compare
HenriqueNogara
approved these changes
Aug 14, 2024
Base automatically changed from
remove_global_current_identity
to
MESH-2209-multisig-improvements-part-4
August 15, 2024 14:07
Base automatically changed from
MESH-2209-multisig-improvements-part-4
to
MESH-1955-multisig-improvements
August 15, 2024 14:08
8498963 to
de5e9d3
Compare
HenriqueNogara
approved these changes
Aug 15, 2024
adamdossa
approved these changes
Aug 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changelog
new features
Identity.KeyRecordsto allow for more efficient permissions checks.modified external API
Identity.KeyRecordsstorage type to only hold the key type (primary, secondary, multisig) and the DID/AccountId. Secondary key permissions have been split out into storageIdentity.KeyExtrinsicPermissions,Identity.KeyAssetPermissions, andIdentity.KeyPortfolioPermissions.DispatchableNametoExtrinsicNameand change it to wrap aStringinstead of raw bytesVec<u8>.PalletNameto wrap aStringinstead of raw bytesVec<u8>.PalletPermissionsto remove thepallet_namefield (pallet name is used as a key the newExtrinsicPermissionstype).Permissionshas been changed to a new typeExtrinsicPermissionswhich uses maps instead of sets.ExternalAgents.GroupPermissionshas changed since the extrinsic permissions uses maps instead of sets now.modified events
Permissionsvalue will have changed (the extrinsic permissions are stored as a map instead of a set).other
get_key_identity_dataandget_did_recordshas changed, since thePermissionstype now uses a map instead of a set for extrinsic permissions.