Added babel parser support for javascript parsing (updated) #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vperron
approved these changes
Oct 6, 2020
Contributor
vperron
left a comment
vperron
left a comment
There was a problem hiding this comment.
agreed, with a very minor comment :)
I think it's fair to also just squash all those commits together, it's goint to be way more atomic this way. Except maybe for the small style / typo changes that are unrelated.
Thank you so much for your contribution !
Knogobert
force-pushed
the
letsnova/master
branch
from
13d8e80 to
a419b83
Compare
Knogobert
force-pushed
the
letsnova/master
branch
from
a419b83 to
2dfe876
Compare
Contributor
Author
|
I have updated according to your comments, good stuff @vperron! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was originally a PR from @ziemenz at #72
Updated to 2.14.0, added some unit tests, updated the readme.
Should be manually tested a bit more first