Skip to content

✅ Comprehensive community round tests (518)#229

Merged
JuaniRios merged 47 commits intomainfrom
feature/plmc-518-comprehensive-community-round-tests
Apr 22, 2024
Merged

✅ Comprehensive community round tests (518)#229
JuaniRios merged 47 commits intomainfrom
feature/plmc-518-comprehensive-community-round-tests

Conversation

@JuaniRios
Copy link
Contributor

@JuaniRios JuaniRios commented Apr 11, 2024

What?

  • Found and fixed critical bug in the price calculation
  • Wrote and modified tests to cover more paths and make code clearer

How?

  • PLMC and Funding asset returns only happen when they are higher than ED. Also wap is taken as min_price when wap is lower than min_price. This can happen due to rounding errors when bucket is increased only by rejected bids.

Testing?

cargo test --features runtime-benchmarks

Anything else?

check https://linear.app/polimec/issue/PLMC-502/community for documentation on all paths covered

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants