Feature/plmc-377-update-to-polkadot-100#123
Merged
Conversation
automatic hrmp connection working Genesis instantiator usage and first draft of HRMP connection formatting feature propagation cleanup new node functioning. genesis not yet sure if working new node functioning. genesis not yet sure if working somehow compiling and test passing save save save feat(287): para_id setting extrinsic implemented and tested save same log crate across workspace same log crate across workspace save save save feat(287): changed tight couple of pallet_xcm by extracting sender trait feat(287): first commit feat(285): POC Hrmp automatic acceptance
# Conflicts: # Cargo.lock # Cargo.toml # integration-tests/src/tests/mod.rs # pallets/funding/Cargo.toml # pallets/funding/src/functions.rs # pallets/funding/src/instantiator.rs # pallets/funding/src/lib.rs # pallets/funding/src/mock.rs # pallets/funding/src/types.rs # pallets/xcm-executor/src/config.rs # pallets/xcm-executor/src/lib.rs # runtimes/standalone/src/lib.rs # runtimes/testnet/src/xcm_config.rs
…s-polimecs-balance-and-pallet # Conflicts: # Cargo.toml
… new map of query id -> unconfirmed transactions
lrazovic
changed the base branch from
main
to
feature/plmc-365-disallow-duplicated-migrations-on-polimec-receiver
lrazovic
commented
Dec 7, 2023
|
|
||
| # This is the 2nd stage: a very small image where we copy the Polkadot binary." | ||
| FROM gcr.io/distroless/cc | ||
| FROM debian:bookworm-slim |
Member
Author
There was a problem hiding this comment.
This change is necessary in order to build an image compatible with Debian 12 that still uses glibc 2.36 when the latest version is 2.38
| type ReserveIdentifier = [u8; 8]; | ||
| /// The ubiquitous event type. | ||
| type RuntimeEvent = RuntimeEvent; | ||
| type RuntimeHoldReason = (); |
Member
Author
There was a problem hiding this comment.
HoldIdentifier is now RuntimeHoldReason
| type Lookup = AccountIdLookup<AccountId, ()>; | ||
| type MaxConsumers = frame_support::traits::ConstU32<16>; | ||
| /// The index type for storing how many extrinsics an account has signed. | ||
| type Nonce = Nonce; |
| )) | ||
| } | ||
|
|
||
| pub fn get_rococo_base_chain_spec() -> Result<ChainSpec, String> { |
Member
Author
There was a problem hiding this comment.
The minimal "base" runtime is now a Parachain on Rococo and can be used to test runtime-upgrades, new pallets, ...
| project_ticket_size: TicketSize<BalanceOf<T>>, | ||
| bid_id: u32, | ||
| now: BlockNumberOf<T>, | ||
| now: BlockNumberFor<T>, |
Member
Author
There was a problem hiding this comment.
Frame System now exposes BlockNumberFor
| #[pallet::genesis_build] | ||
| #[cfg(not(all(feature = "testing-node", feature = "std")))] | ||
| impl<T: Config> GenesisBuild<T> for GenesisConfig<T> { | ||
| impl<T: Config> BuildGenesisConfig for GenesisConfig<T> { |
Member
Author
There was a problem hiding this comment.
GenesisBuild<T> is deprecated and replaced by BuildGenesisConfig
Comment on lines
-58
to
-61
| pub enum TestRuntime where | ||
| Block = Block, | ||
| NodeBlock = Block, | ||
| UncheckedExtrinsic = UncheckedExtrinsic, |
Member
Author
There was a problem hiding this comment.
The where block in the construct_runtime! macro is now detracted and it's not needed anymore.
| } | ||
|
|
||
| #[cfg(feature = "std")] | ||
| impl<T: Config> Default for GenesisConfig<T> { |
Member
Author
There was a problem hiding this comment.
This is now derived using #[derive(frame_support::DefaultNoBound)]
…mec-receiver' into feature/plmc-377-update-to-polkadot-100
…mec-receiver' into feature/plmc-377-update-to-polkadot-100
lrazovic
changed the base branch from
feature/plmc-365-disallow-duplicated-migrations-on-polimec-receiver
to
main
lrazovic
commented
Dec 7, 2023
| SiblingParachainAsNative, SiblingParachainConvertsVia, SignedAccountId32AsNative, SignedToAccountId32, | ||
| SovereignSignedViaLocation, TakeWeightCredit, UsingComponents, WithComputedOrigin, | ||
| }; | ||
| use xcm_executor::traits::{Error, JustTry, MatchesFungibles, Properties, ShouldExecute}; |
Member
Author
There was a problem hiding this comment.
The Convert trait from xcm_executor was removed, with @vstam1 we replaced it using the MaybeEquivalence trait from sp_runtime
vstam1
approved these changes
Dec 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converttrait from thexcm_executor.construct_runtime!macro is the one change in the right direction that allows difficult syntax to be removed from inside an already quite complicated macro.Block,NodeBlockandUncheckedExtrinsictoframe_system, insteadconstruct_runtimeparitytech/substrate#14126GenesisBuild<T,I>is now deprecated.BuildGenesisConfigis the new cool kids on the block .GenesisBuild<T,I>deprecated.BuildGenesisConfigadded. paritytech/substrate#14306