[codex] Recompute future SPM thresholds#7943
Draft
MaxGhenis wants to merge 1 commit intoPolicyEngine:mainfrom
Draft
[codex] Recompute future SPM thresholds#7943MaxGhenis wants to merge 1 commit intoPolicyEngine:mainfrom
MaxGhenis wants to merge 1 commit intoPolicyEngine:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7943 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 17 32 +15
=========================================
+ Hits 17 32 +15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
spm_unit_spm_thresholdas a generic uprated input in future yearsWhy
SPM thresholds should not just be carried forward by CPI on the total stored amount. That loses the structure we built this for: the reference threshold, the equivalence scale, and the unit-specific geographic adjustment.
Impact
Future-year SPM thresholds in
policyengine-usnow respond to household composition and tenure changes while preserving the implied geographic adjustment from the stored base-year threshold.Root cause
spm_unit_spm_thresholdwas defined as an input variable withgov.bls.cpi.cpi_uuprating, so future periods inherited a simple scalar uprate of the total threshold instead of recomputing the threshold components.Validation
PYTHONPATH=. pytest -q policyengine_us/tests/policy/baseline/household/income/spm_unit