Add CTC artifact comparison diagnostics to national validation#731
Merged
Add CTC artifact comparison diagnostics to national validation#731
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validate_national_h5for artifact-to-artifact CTC comparisonsWhy
This implements the validation half of #725. We can already compare aggregate CTC totals, but recent adjacent artifacts showed that CTC reform sensitivity can move because the child composition moves even when top-line current-law totals stay close.
Using the new comparison output on adjacent staged national artifacts showed:
ctc_qualifying_childrenmoved only about-570kThat is exactly the failure mode we need the validator to surface.
Issue tracking
Testing
uv run pytest tests/unit/calibration/test_validate_national_h5.py -quv run pytest tests/unit/calibration/test_ctc_diagnostics.py -quv run ruff check policyengine_us_data/calibration/validate_national_h5.py tests/unit/calibration/test_validate_national_h5.pyuv run python -m policyengine_us_data.calibration.validate_national_h5 --help