Skip to content

Stop defaulting Simulation() to a private dataset#1554

Merged
MaxGhenis merged 2 commits intomainfrom
codex/fix-private-default-dataset
Apr 6, 2026
Merged

Stop defaulting Simulation() to a private dataset#1554
MaxGhenis merged 2 commits intomainfrom
codex/fix-private-default-dataset

Conversation

@MaxGhenis
Copy link
Copy Markdown
Collaborator

Summary

  • remove the hardcoded private Hugging Face dataset from bare Simulation() / Microsimulation() initialization
  • require an explicit dataset when no situation is provided, unless POLICYENGINE_UK_DEFAULT_DATASET is explicitly set
  • add regression tests covering both the explicit error path and the opt-in env-var path

This is a corrective follow-up to the merged default-dataset change. It avoids silently reaching into a private HF repo from the public package.

Verification

  • pytest policyengine_uk/tests/test_deterministic_variables.py::TestDefaultDatasetUrl -q

@MaxGhenis MaxGhenis merged commit 9c31db7 into main Apr 6, 2026
2 checks passed
@MaxGhenis MaxGhenis deleted the codex/fix-private-default-dataset branch April 6, 2026 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant