Skip to content

Refactor varying your earnings test#2694

Merged
anth-volk merged 1 commit intomasterfrom
test/modify-varying-your-earnings
Aug 4, 2025
Merged

Refactor varying your earnings test#2694
anth-volk merged 1 commit intomasterfrom
test/modify-varying-your-earnings

Conversation

@anth-volk
Copy link
Copy Markdown
Collaborator

Fixes #2692

Refactors the varying your earnings test to better serve as an integration test by:

  • Correctly coding fixtures
  • Removing duplicative fixtures that divorce the test from the context it's testing
  • Running only one sim instead of three, a holdover from the original purpose of this test that is no longer necessary

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.60%. Comparing base (0d41b7b) to head (aca4b07).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2694      +/-   ##
==========================================
- Coverage   81.23%   80.60%   -0.63%     
==========================================
  Files          49       49              
  Lines        1609     1609              
  Branches      208      208              
==========================================
- Hits         1307     1297      -10     
- Misses        254      264      +10     
  Partials       48       48              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@anth-volk anth-volk merged commit 0717bd2 into master Aug 4, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor Varying your earnings test to be more performant and stable; don't test for old edge case from -core

1 participant