Fix arm builds#612
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #612 +/- ##
========================================
Coverage ? 34.6%
========================================
Files ? 67
Lines ? 7840
Branches ? 1883
========================================
Hits ? 2713
Misses ? 4367
Partials ? 760 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The latest plume sources need LLVM 8.0.0 for compilation. This PR bumps LLVM and restores arm64 builds.
arm32 builds should work but nix is currently broken for builds. See #611 for more information on the arm32 breakages. Once nix is updated, this should also fix arm32 builds.
I've also removed a pair of comments that reference unneeded LLVM tools.