Merged
Conversation
7 tasks
mcm001
reviewed
Feb 18, 2026
Member
Author
|
There's likely a better way to do this, I'm pulling from what Thad did for now to get an MVP. We can do cleanup later. |
mcm001
reviewed
Feb 19, 2026
Co-authored-by: Matt Morley <matthew.morley.ca@gmail.com>
samfreund
force-pushed
the
hash-native-libraries
branch
from
bd768ae to
164fc9e
Compare
samfreund
force-pushed
the
hash-native-libraries
branch
from
518c868 to
3fd9481
Compare
samfreund
force-pushed
the
hash-native-libraries
branch
from
af8b78f to
c0f6c9a
Compare
mcm001
force-pushed
the
hash-native-libraries
branch
from
ddb3098 to
417c087
Compare
mcm001
approved these changes
Feb 19, 2026
mcm001
added a commit
to PhotonVision/photonvision
that referenced
this pull request
Feb 19, 2026
## Description We've hit a problem where the `CombinedRuntimeLoader` extracts native files, but gets interrupted in the middle. This is bad, cause all `CombinedRuntimeLoader` used to check a file was its existence. This change uses the hash of the file to verify that it's correct. This will be checked at runtime, everytime, if the file is extant. If this check fails, we will delete the extant file and attempt to reextract. We also check a newly extracted file, if that hash does not match we error. Note that this is reliant on PhotonVision/wpilib-tool-plugin#8 and should follow #2367 ## Meta Merge checklist: - [x] Pull Request title is [short, imperative summary](https://cbea.ms/git-commit/) of proposed changes - [x] The description documents the _what_ and _why_, including events that led to this PR - [ ] If this PR changes behavior or adds a feature, user documentation is updated - [ ] If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly - [ ] If this PR touches configuration, this is backwards compatible with all settings going back to the previous seasons's last release (seasons end after champs ends) - [ ] If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated - [ ] If this PR addresses a bug, a regression test for it is added --------- Co-authored-by: Matt M <matthew.morley.ca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the way native libraries are enumerated in the
ResourceInformation.jsonfile. Previously, we used a list of filenames. We now use a map of filenames:MD5_hash. This allows us to check the hashes of native libraries as they're extracted.