Skip to content

Restart NT client every 5 seconds if not connected #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mcm001 merged 4 commits into from
Oct 19, 2022
Merged

Restart NT client every 5 seconds if not connected #467

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6f8b49d
Restart NT client every 5 seconds if not connected
mcm001 May 13, 2022
80f5f46
Update NetworkTablesManager.java
mcm001 May 13, 2022
9760c5f
Merge branch 'master' into nt-connection-hack
shueja Oct 17, 2022
2aef507
Merge branch 'master' into nt-connection-hack
shueja Oct 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions ...re/src/main/java/org/photonvision/common/dataflow/networktables/NetworkTablesManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
import java.util.HashMap;
import java.util.function.Consumer;
import org.photonvision.PhotonVersion;
import org.photonvision.common.configuration.ConfigManager;
import org.photonvision.common.configuration.NetworkConfig;
import org.photonvision.common.dataflow.DataChangeService;
import org.photonvision.common.dataflow.events.OutgoingUIEvent;
Expand All @@ -39,6 +40,7 @@ public class NetworkTablesManager {

private NetworkTablesManager() {
ntInstance.addLogger(new NTLogger(), 0, 255); // to hide error messages
TimedTaskManager.getInstance().addTask("NTManager", this::ntTick, 5000);
}

private static NetworkTablesManager INSTANCE;
Expand Down Expand Up @@ -129,4 +131,16 @@ private void setServerMode() {
ntInstance.startServer();
broadcastVersion();
}

// So it seems like if Photon starts before the robot NT server does, and both aren't static IP,
// it'll never connect. This hack works around it by restarting the client/server while the nt
// instance
// isn't connected, same as clicking the save button in the settings menu (or restarting the
// service)
private void ntTick() {
if (!ntInstance.isConnected()
&& !ConfigManager.getInstance().getConfig().getNetworkConfig().runNTServer) {
setConfig(ConfigManager.getInstance().getConfig().getNetworkConfig());
}
}
}