Skip to content

Rknn cleaner#2404

Open
Bobcat66 wants to merge 3 commits intoPhotonVision:mainfrom
Bobcat66:rknn_cleaner
Open

Rknn cleaner#2404
Bobcat66 wants to merge 3 commits intoPhotonVision:mainfrom
Bobcat66:rknn_cleaner

Conversation

@Bobcat66
Copy link

Description

What changed? Why? (the code + comments should speak for itself on the "how")

Removed the strong reference in the Object Detector cleaners, which prevented the object from ever being cleaned up

Include fun testing screenshots or a cool video, to collect test evidence in a place where we can later reference it. Including proof this change was tested makes reviewing easier, helps us make sure we tested all our edge cases, and helps provide context for the future.

Any issues this pull request closes or pull requests this supersedes should be linked with Closes #issuenumber.

Closes #2044

Meta

Merge checklist:

  • Pull Request title is short, imperative summary of proposed changes
  • The description documents the what and why, including events that led to this PR
  • If this PR changes behavior or adds a feature, user documentation is updated
  • If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly
  • If this PR touches configuration, this is backwards compatible with all settings going back to the previous seasons's last release (seasons end after champs ends)
  • If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated
  • If this PR addresses a bug, a regression test for it is added
  • If this PR adds a dependency, the license has been checked for compatibility and steps taken to follow it

@Bobcat66 Bobcat66 requested a review from a team as a code owner March 19, 2026 06:27
@github-actions github-actions bot added the backend Things relating to photon-core and photon-server label Mar 19, 2026
@Gold856
Copy link
Member

Gold856 commented Mar 19, 2026

Your solution is a bit overkill. Cleaner offers guarantees that make most of the logic that was previously necessary unneeded. Look into the docs for Cleaner, and also how it's implemented here: https://github.com/wpilibsuite/allwpilib/blob/7ca35e5678cf32caec6a1a866ca51d0136c4c398/wpinet/src/main/java/edu/wpi/first/net/MulticastServiceAnnouncer.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend Things relating to photon-core and photon-server

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix cleaner issues

2 participants