Thermal throttling +typos

[Ruthie-FRC]

Description

What changed? Why? (the code + comments should speak for itself on the "how")

Include fun testing screenshots or a cool video, to collect test evidence in a place where we can later reference it. Including proof this change was tested makes reviewing easier, helps us make sure we tested all our edge cases, and helps provide context for the future.

adds thermal throttling feature. cleans up spelling. resolves #2289

Any issues this pull request closes or pull requests this supersedes should be linked with Closes #issuenumber.

Meta

Merge checklist:

• Pull Request title is short, imperative summary of proposed changes
• The description documents the what and why, including events that led to this PR
• If this PR changes behavior or adds a feature, user documentation is updated
• If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly
• If this PR touches configuration, this is backwards compatible with all settings going back to the previous seasons's last release (seasons end after champs ends)
• If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated
• If this PR addresses a bug, a regression test for it is added
• If this PR adds a dependency, the license has been checked for compatibility and steps taken to follow it

[Ruthie-FRC]

i always forget to lint...

[Gold856]

In other places, we put in a call to SmartDashboard.updateValues() after updating alerts. Looks like the AI missed it here. I think we ought to add it here as well.

[Ruthie-FRC]

In other places, we put in a call to SmartDashboard.updateValues() after updating alerts. Looks like the AI missed it here. I think we ought to add it here as well.

AI? I didn't use AI...

I just forgot to add the call, sorry about that.

[Gold856]

Looks awfully similar to Ruthie-FRC#1. Fine if you use AI, but you do need to clean stuff up like that.

[Ruthie-FRC]

Looks awfully similar to Ruthie-FRC#1. Fine if you use AI, but you do need to clean stuff up like that.

I try writing my code first and then see if i do things right because I dont want to mess up horribly. in this case i forgot to do it and so did double checking the code.

[Gold856]

That's cool then. Just was wondering.

[Ruthie-FRC]

That's cool then. Just was wondering.

No worries. sorry if i got defensive, i just have a fear of messing up things in public, especially to people who maintain repos I look up to (such as everyone who works at photonvision). still managed to do it though...

[Gold856]

You're good.

[Ruthie-FRC]

i fixed the linting issue @Gold856

[Ruthie-FRC]

I think i updated it but github is being weird so idk if it pushed propperly

[spacey-sooty]

I don't see the change requested by craig yet?

[Ruthie-FRC]

I don't see the change requested by craig yet?

thank you. my computer was being weird, it said it pushed on my end but didnt show up over here so i wasnt sure. sorry abt that

[Ruthie-FRC]

@spacey-sooty fixed it sorry about the delay

[spacey-sooty]

If you throw this in photon targetting you shouldn't need to duplicate it