Disallow low-resolution calibration#2390
Open
cswilson252 wants to merge 4 commits intoPhotonVision:mainfrom
Open
Disallow low-resolution calibration#2390cswilson252 wants to merge 4 commits intoPhotonVision:mainfrom
cswilson252 wants to merge 4 commits intoPhotonVision:mainfrom
Conversation
github-actions
bot
added
the
frontend
Member
|
Would a total pixel count (area) be a better metric than a specific vert/horiz pixel count cutoff? |
Contributor
|
I think that area, or maybe diagonal length in pixels to keep the units in pixels, are better than just width or height? |
mcm001
reviewed
Mar 9, 2026
Comment on lines
+185
to
+186
| if ((calMode && currentRes.width > 640) || (calMode && currentRes.height > 480)) { | ||
| useStateStore().showSnackbarMessage({ |
Contributor
There was a problem hiding this comment.
I feel like a v-alert similar to the mrcal pop-up might be a better choice? Keeps the warning closer to the thing we care about.
Contributor
There was a problem hiding this comment.
Or actually why even allow calibrations? why not filter them from the dropdown before the user even gets a chance to select it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What changed? Why? (the code + comments should speak for itself on the "how")
Adds a snackbar message (error) in
CameraCalibrationCardif calibration resolution is < 640x480, because there's not enough useful data for calibration at that scale.Closes #1719
Meta
Merge checklist: