Add composite pipeline for tags and object detection#2351
Open
halfaleague wants to merge 2 commits intoPhotonVision:mainfrom
Open
Add composite pipeline for tags and object detection#2351halfaleague wants to merge 2 commits intoPhotonVision:mainfrom
halfaleague wants to merge 2 commits intoPhotonVision:mainfrom
Conversation
github-actions
bot
added
frontend
Author
|
Thoughts? Is this in the right direction? |
Member
Looks promising! I don't have the time to review rn, but I'll try and make that happen sometime tonight. It would be great if you could update your branch so it's up to date with main too. |
Contributor
|
I think that #2262 is the better direction of the two approaches personally |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PhotonVision pipelines currently run a single primary operation at a time (e.g., AprilTags or object detection), which prevents concurrent tag + object use on the same
camera stream. This PR adds a composite pipeline that runs both on the same frame, publishes combined results plus separate tag/object NetworkTables outputs, and draws both
overlays in the output stream. UI and frontend typing are updated to expose the composite pipeline and per-op enable toggles. This is additive and does not change existing
pipeline behavior.
Testing + evidence:
./gradlew :photon-server:shadowJar -PArchOverride=linuxarm64 -Ponlylinuxarm64