Dynamically import echarts and three.js#2349
Merged
mcm001 merged 1 commit intoPhotonVision:mainfrom Feb 2, 2026
Merged
Conversation
mcm001
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This splits echarts into its own bundle to speed up the initial page load, and dynamically imports it so it's only loaded when a user navigates to the settings page. This also fixes an issue with the three.js dynamic import where the import was immediately awaited, so the page load was blocked on loading three.js.
old.mp4
Note the UI isn't displayed until after three.js is fully downloaded.
new.mp4
Note that the initial JS bundle is much smaller and three.js is loaded after the UI loads.
Meta
Merge checklist: