Copy old configs before testing#2348
Merged
Gold856 merged 2 commits intoPhotonVision:mainfrom Feb 2, 2026
Merged
Conversation
mcm001
reviewed
Feb 2, 2026
photon-core/src/test/java/org/photonvision/common/configuration/SQLConfigTest.java
Outdated
Show resolved
Hide resolved
mcm001
approved these changes
Feb 2, 2026
photon-core/src/test/java/org/photonvision/common/configuration/SQLConfigTest.java
Show resolved
Hide resolved
ae65745 to
741c0d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Presently, any tests using our old configs happen in place. This is problematic, as it changes the files themselves. This means that anyone running the tests will cause unintentional modifications, which stand a chance of being committed and merged into main. We want these old database files to remain untouched, thus we copy them to a temp directory prior to running our tests.
Meta
Merge checklist: