Skip to content

Copy old configs before testing#2348

Merged
Gold856 merged 2 commits intoPhotonVision:mainfrom
samfreund:copy-database-testing
Feb 2, 2026
Merged

Copy old configs before testing#2348
Gold856 merged 2 commits intoPhotonVision:mainfrom
samfreund:copy-database-testing

Conversation

@samfreund
Copy link
Member

@samfreund samfreund commented Feb 2, 2026

Description

Presently, any tests using our old configs happen in place. This is problematic, as it changes the files themselves. This means that anyone running the tests will cause unintentional modifications, which stand a chance of being committed and merged into main. We want these old database files to remain untouched, thus we copy them to a temp directory prior to running our tests.

Meta

Merge checklist:

  • Pull Request title is short, imperative summary of proposed changes
  • The description documents the what and why, including events that led to this PR
  • If this PR changes behavior or adds a feature, user documentation is updated
  • If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly
  • If this PR touches configuration, this is backwards compatible with all settings going back to the previous seasons's last release (seasons end after champs ends)
  • If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated
  • If this PR addresses a bug, a regression test for it is added

@samfreund samfreund requested a review from a team as a code owner February 2, 2026 01:09
@github-actions github-actions bot added the backend Things relating to photon-core and photon-server label Feb 2, 2026
@samfreund samfreund requested a review from mcm001 February 2, 2026 02:03
@samfreund samfreund force-pushed the copy-database-testing branch from ae65745 to 741c0d8 Compare February 2, 2026 02:10
@samfreund samfreund enabled auto-merge (squash) February 2, 2026 02:11
@Gold856 Gold856 changed the title Copy old_configs before testing Copy old configs before testing Feb 2, 2026
@Gold856 Gold856 disabled auto-merge February 2, 2026 02:35
@Gold856 Gold856 enabled auto-merge (squash) February 2, 2026 02:35
@Gold856 Gold856 merged commit 798b01c into PhotonVision:main Feb 2, 2026
93 of 94 checks passed
@samfreund samfreund deleted the copy-database-testing branch February 2, 2026 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend Things relating to photon-core and photon-server

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants