Add missing early-return to legacy ML model load#2347
Merged
mcm001 merged 5 commits intoPhotonVision:mainfrom Feb 2, 2026
Merged
Add missing early-return to legacy ML model load#2347mcm001 merged 5 commits intoPhotonVision:mainfrom
mcm001 merged 5 commits intoPhotonVision:mainfrom
Conversation
mcm001
reviewed
Feb 2, 2026
photon-core/src/main/java/org/photonvision/common/configuration/NeuralNetworkModelManager.java
Show resolved
Hide resolved
mcm001
reviewed
Feb 2, 2026
photon-core/src/main/java/org/photonvision/common/configuration/NeuralNetworkModelManager.java
Outdated
Show resolved
Hide resolved
mcm001
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously, when attempting to load a model that did not follow the old naming pattern that was in the models directory, we caused PV to crash due to a missing early return (reproducable on this branch with the extra bonus ML model and missing label file):
This PR fixes it by adding the missing early-return, and adding unit tests to make sure we handle this.
Meta
Merge checklist: