Check POST request status before displaying success#2336
Merged
mcm001 merged 1 commit intoPhotonVision:mainfrom Jan 27, 2026
Merged
Check POST request status before displaying success#2336mcm001 merged 1 commit intoPhotonVision:mainfrom
mcm001 merged 1 commit intoPhotonVision:mainfrom
Conversation
60da7d6 to
7a6b5d1
Compare
samfreund
approved these changes
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We currently don't check if the POST request succeeded before immediately sprinting off to reload the page. This often means users see a green "reloading" notification, which I think is masking issues in https://www.chiefdelphi.com/t/photonvision-offline-updating-to-2026-1-1-not-working/512677. Confirmed that a disconnected UI (the demo page) will always show that green reloading notification. Fix this by making
axiosPostreturn whether or not the POST request succeeded, and only refresh if it succeeded. This also similarly pulls out the snackbar message displayed on upload completion out of the upload progress callback and into an if statement because it's cleaner and avoids potential rounding errors causing it to not display.original.mp4
new.mp4
Meta
Merge checklist: