Add saturation slider - #2324
Open
spacey-sooty wants to merge 4 commits into
Open
Conversation
github-actions
Bot
added
frontend
spacey-sooty
force-pushed
the
add-saturation-slider
branch
from
January 22, 2026 03:45
1176bd3 to
639e622
Compare
spacey-sooty
force-pushed
the
add-saturation-slider
branch
from
January 30, 2026 03:13
b64a5af to
6d61d77
Compare
mcm001
reviewed
Mar 4, 2026
spacey-sooty
force-pushed
the
add-saturation-slider
branch
3 times, most recently
from
June 29, 2026 17:04
b9a8d74 to
2c45e6a
Compare
spacey-sooty
force-pushed
the
add-saturation-slider
branch
from
July 6, 2026 07:53
2c45e6a to
2acf621
Compare
Resolves PhotonVision#2311 Signed-off-by: Jade Turner <spacey-sooty@proton.me>
spacey-sooty
force-pushed
the
add-saturation-slider
branch
from
July 20, 2026 18:48
2acf621 to
89a78e2
Compare
Member
Author
|
Tested and working well on both my laptop camera and LL3, needs PhotonVision/photon-libcamera-gl-driver#29 |
mcm001
reviewed
Jul 20, 2026
Comment on lines
+206
to
+207
| cameraMinSaturation: 0, | ||
| cameraMaxSaturation: 100, |
Contributor
There was a problem hiding this comment.
Based on #2324 (comment) -- can we have the UI assume 0-100 in all cases?
Member
Author
There was a problem hiding this comment.
Its a fine default, it'll work for CSI cams and USB cams. It pulls from getMax and getMin if not
Contributor
There was a problem hiding this comment.
Do you think the slider should always be 0-100, and we can rescale in the backend?
mcm001
reviewed
Jul 20, 2026
mcm001
reviewed
Jul 20, 2026
Comment on lines
+121
to
+122
| this.minSaturation = saturationProp.getMin(); | ||
| this.maxSaturation = saturationProp.getMax(); |
Contributor
There was a problem hiding this comment.
Is this always 0-100, or is it ever different? (Related to thread above)
Member
Author
There was a problem hiding this comment.
All the cameras I've tried return 0-100 but I believe it can be other things
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added a saturation slider, tested on my laptops in built camera.
Resolves #2311
Meta
Merge checklist: