Enable NM 1.52 link-local fallback resolution#2321
Draft
thatcomputerguy0101 wants to merge 11 commits intoPhotonVision:2027from
Draft
Enable NM 1.52 link-local fallback resolution#2321thatcomputerguy0101 wants to merge 11 commits intoPhotonVision:2027from
thatcomputerguy0101 wants to merge 11 commits intoPhotonVision:2027from
Conversation
Signed-off-by: Jade Turner <[email protected]>
## Description Added systemcore to a couple of build files in order for `./gradlew publishToMavenLocal` to generate systemcore-compatible dependencies. Needed to support deploying photonlib to systemcore. ## Meta Merge checklist: - [x] Pull Request title is [short, imperative summary](https://cbea.ms/git-commit/) of proposed changes - [x] The description documents the _what_ and _why_ - [ ] If this PR changes behavior or adds a feature, user documentation is updated - [ ] If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly - [ ] If this PR touches configuration, this is backwards compatible with settings back to v2024.3.1 - [ ] If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated - [ ] If this PR addresses a bug, a regression test for it is added --------- Co-authored-by: Gold856 <[email protected]>
github-actions
bot
added
the
backend
Contributor
Author
|
It would probably be good to mention this in the documentation, but I don't think there is currently a section talking about DHCP. |
Contributor
|
Yeah, I don't believe our documentation talks about networking very much at all. It seems like a common enough foot gun. It may be worth mentioning, although most people probably don't need to know very much |
github-actions
bot
added
the
documentation
Contributor
Author
|
I added some draft documentation, although I'm unsure if I got the level of detail right. |
Gold856
force-pushed
the
2027
branch
2 times, most recently
from
4153f8b to
4d1f0a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This enables link-local as a fallback to DHCP address resolution, using the new features of NetworkManager 1.52. Debian 13 (Trixie) and Ubuntu 26.04 (Resolute) introduce the required updates to NetworkManager for this to work. Unlike #1550, this continues to timeout and retry DHCP while holding a link-local address, which should avoid breaking compatibility with DHCP servers that don't respond immediately.
Closes #1813, blocked on updating the images to have NM 1.52 or later.
Meta
Merge checklist: