Cache requested calibration format outside of state store#2310
Merged
mcm001 merged 1 commit intoPhotonVision:mainfrom Jan 18, 2026
Merged
Cache requested calibration format outside of state store#2310mcm001 merged 1 commit intoPhotonVision:mainfrom
mcm001 merged 1 commit intoPhotonVision:mainfrom
Conversation
spacey-sooty
approved these changes
Jan 18, 2026
Member
spacey-sooty
left a comment
There was a problem hiding this comment.
Makes sense, love the testing screenshots
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On main, this pop-up lists the wrong resolution. The index in the state is getting updated out from underneath us. The easiest solution I have is to just cache this number.
Not sure of a great way to test this, since it requires the backend taking calibration snapshots
Meta
Merge checklist: