Skip to content

Cache requested calibration format outside of state store#2310

Merged
mcm001 merged 1 commit intoPhotonVision:mainfrom
mcm001:cal-complete-banner
Jan 18, 2026
Merged

Cache requested calibration format outside of state store#2310
mcm001 merged 1 commit intoPhotonVision:mainfrom
mcm001:cal-complete-banner

Conversation

@mcm001
Copy link
Contributor

@mcm001 mcm001 commented Jan 18, 2026

Description

On main, this pop-up lists the wrong resolution. The index in the state is getting updated out from underneath us. The easiest solution I have is to just cache this number.

image image

Not sure of a great way to test this, since it requires the backend taking calibration snapshots

Meta

Merge checklist:

  • Pull Request title is short, imperative summary of proposed changes
  • The description documents the what and why
  • If this PR changes behavior or adds a feature, user documentation is updated
  • If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly
  • If this PR touches configuration, this is backwards compatible with settings back to v2025.3.2
  • If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated
  • If this PR addresses a bug, a regression test for it is added

@mcm001 mcm001 requested a review from a team as a code owner January 18, 2026 15:37
@github-actions github-actions bot added the frontend Having to do with PhotonClient and its related items label Jan 18, 2026
Copy link
Member

@spacey-sooty spacey-sooty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, love the testing screenshots

@mcm001 mcm001 enabled auto-merge (squash) January 18, 2026 15:39
@mcm001 mcm001 merged commit dbd6eea into PhotonVision:main Jan 18, 2026
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend Having to do with PhotonClient and its related items

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants