Serve denial page on SystemCore#2302
Open
samfreund wants to merge 12 commits intoPhotonVision:2027from
Open
Conversation
Signed-off-by: Jade Turner <[email protected]>
## Description Added systemcore to a couple of build files in order for `./gradlew publishToMavenLocal` to generate systemcore-compatible dependencies. Needed to support deploying photonlib to systemcore. ## Meta Merge checklist: - [x] Pull Request title is [short, imperative summary](https://cbea.ms/git-commit/) of proposed changes - [x] The description documents the _what_ and _why_ - [ ] If this PR changes behavior or adds a feature, user documentation is updated - [ ] If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly - [ ] If this PR touches configuration, this is backwards compatible with settings back to v2024.3.1 - [ ] If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated - [ ] If this PR addresses a bug, a regression test for it is added --------- Co-authored-by: Gold856 <[email protected]>
7 tasks
70eb03a to
28459e3
Compare
Member
Author
|
Not sure why this is failing, I think we need to rebase main onto 2027 |
Contributor
|
Yeah git history is wonky |
Member
|
Whoops. Guess that's what we get for rebasing... |
Member
|
Oh I've seen similar to this working on other things, if you rebase again you should be able to get rid of it this happens due to the order certain things are rebased. Its weird |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We don't want to officially support SystemCore. This PR serves a page delineating why SC isn't supported.
Supercedes #2170 cause I'm too lazy to fix the git history.
Meta
Merge checklist: