Skip to content

Propagate changes after modifying OD model#2299

Merged
mcm001 merged 6 commits intoPhotonVision:mainfrom
samfreund:reload-od
Jan 19, 2026
Merged

Propagate changes after modifying OD model#2299
mcm001 merged 6 commits intoPhotonVision:mainfrom
samfreund:reload-od

Conversation

@samfreund
Copy link
Member

@samfreund samfreund commented Jan 15, 2026

Description

This PR adjusts how model modification is handled. Any updates to metadata, or deletion is handled in the frontend after sending data to the backend. Any creation of models occurs in the backend, and we push an update to the frontend.

This PR also fixes a typo in PhotonUtils which meant we hit the wrong endpoint when an IP was passed into the status check.

Meta

Merge checklist:

  • Pull Request title is short, imperative summary of proposed changes
  • The description documents the what and why
  • If this PR changes behavior or adds a feature, user documentation is updated
  • If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly
  • If this PR touches configuration, this is backwards compatible with settings back to v2025.3.2
  • If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated
  • If this PR addresses a bug, a regression test for it is added

@samfreund samfreund requested a review from a team as a code owner January 15, 2026 02:12
@github-actions github-actions bot added the frontend Having to do with PhotonClient and its related items label Jan 15, 2026
@samfreund samfreund changed the title Force a reload after modifying OD models to propagate changes Propagate changes after modifying OD model Jan 15, 2026
@github-actions github-actions bot added the backend Things relating to photon-core and photon-server label Jan 15, 2026
@samfreund samfreund requested a review from mcm001 January 15, 2026 06:11
@spacey-sooty
Copy link
Member

Code looks reasonable, have you tested it?

@samfreund
Copy link
Member Author

@mcm001 mcm001 merged commit 6c9a142 into PhotonVision:main Jan 19, 2026
58 checks passed
@samfreund samfreund deleted the reload-od branch January 26, 2026 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend Things relating to photon-core and photon-server frontend Having to do with PhotonClient and its related items

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants