fix: simplify version regex and fix rc tag handling#2296
Merged
mcm001 merged 1 commit intoPhotonVision:mainfrom Jan 13, 2026
Merged
fix: simplify version regex and fix rc tag handling#2296mcm001 merged 1 commit intoPhotonVision:mainfrom
mcm001 merged 1 commit intoPhotonVision:mainfrom
Conversation
- Move v prefix outside capture group in regex - Add rc to maturity group (beta|alpha|rc) - Fixes InvalidVersion error for rc tags Amp-Thread-ID: https://ampcode.com/threads/T-019bb77f-d3b6-7618-b511-4109f328102f Co-authored-by: Amp <amp@ampcode.com>
mcm001
approved these changes
Jan 13, 2026
|
@auscompgeek ... will this fix address the current inability to load the proper latest photonlibpy via pyproject.toml in robot projects (in the next few days or next release here)? (or should I open up a separate new issue about not being able to install anything beyond "photonlibpy==2026.0.1-beta" (which still was tied to 2025 of course). |
Contributor
Author
|
This PR only does what it says on the tin. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The hand-rolled version generation was ignoring RC tags. When removing the RC tag filter, it broke:
This fixes that, and simplifies the regex slightly so it's clearer what on earth is happening. Some surrounding code to handle PEP 440 versioning is also cleaned up to squash a warning we get otherwise for RCs:
Amp-Thread-ID: https://ampcode.com/threads/T-019bb77f-d3b6-7618-b511-4109f328102f
Meta
Merge checklist: