Rewrite system monitoring to use OSHI by crschardt · Pull Request #2255 · PhotonVision/photonvision

crschardt · 2025-12-24T00:00:58Z

Description

OSHI is a free (MIT license) JNA-based library for accessing hardware and system performance information. This PR includes a re-write of the metrics monitoring code to be based on OSHI. The original intent was to gain access to data about network traffic for addition to the Settings tab. An additional benefit is that collecting the data is now around two orders of magnitude (or more) faster!

Meta

Merge checklist:

Pull Request title is short, imperative summary of proposed changes
The description documents the what and why
If this PR changes behavior or adds a feature, user documentation is updated
If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly
If this PR touches configuration, this is backwards compatible with settings back to v2025.3.2
If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated
If this PR addresses a bug, a regression test for it is added

photon-core/src/main/java/org/photonvision/common/hardware/HardwareManager.java

photon-core/src/main/java/org/photonvision/common/hardware/metrics/SystemMonitor.java

photon-server/src/main/java/org/photonvision/server/RequestHandler.java

photon-core/src/main/java/org/photonvision/common/hardware/metrics/DeviceMetrics.java

…lean up.

samfreund · 2025-12-31T04:32:43Z

Works on my laptop/rubik, remove fetch button, add current monitoring for rubik if possible so we can warn when we're under 12v.

photon-core/src/main/java/org/photonvision/common/hardware/metrics/SystemMonitor.java

...on-core/src/main/java/org/photonvision/common/hardware/metrics/SystemMonitorRaspberryPi.java

photon-core/src/main/java/org/photonvision/common/hardware/metrics/SystemMonitorRK3588.java

…rdt/photonvision into feat/oshi-metrics-manager

photon-core/src/main/java/org/photonvision/common/hardware/metrics/SystemMonitor.java

photon-client/src/stores/settings/GeneralSettingsStore.ts

…anager

photon-core/src/main/java/org/photonvision/common/hardware/metrics/cmds/QCS6490Cmds.java

…tation (#2343) ## Description #2255 introduced a new, cross-platform method for monitoring hardware and removed the custom shell commands that had been used previously. This PR updates the documentation to reflect the removal of those commands from hardwareConfig.json. ## Meta Merge checklist: - [x] Pull Request title is [short, imperative summary](https://cbea.ms/git-commit/) of proposed changes - [x] The description documents the _what_ and _why_, including events that led to this PR - [ ] If this PR changes behavior or adds a feature, user documentation is updated - [ ] If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly - [ ] If this PR touches configuration, this is backwards compatible with all settings going back to the previous seasons's last release (seasons end after champs ends) - [ ] If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated - [ ] If this PR addresses a bug, a regression test for it is added --------- Co-authored-by: Gold856 <117957790+Gold856@users.noreply.github.com>

crschardt added 18 commits December 21, 2025 15:17

initial oshi integration

598827b

use Files for getting available disk space

1a2d198

log mebibytes

5530413

try diozero for cpu temperature

14a38bb

monitor cpu

259662a

basic network traffic tracking

a71c224

monitor almost everything with oshi

b1e27a1

add subclass for RaspberryPi-specific items

55cf8e0

add subclass for RK3588 NPU load

26e94f1

replace MetricsManager with SystemMonitor

24f8256

fix number (lack of) formatting

88e0ca0

improved profiling

0c2778a

enable logging of DeviceMetrics for debugging

400fd0f

show network traffic in UI

d937abd

publish metrics should only be called from the monitor

7e64729

test adding jLibreHardwareMonitor for Windows computers

f7544ae

it didn't help

ef14940

acknowledge OSHI

1e7a480

github-actions bot added frontend Having to do with PhotonClient and its related items backend Things relating to photon-core and photon-server labels Dec 24, 2025

samfreund requested changes Dec 24, 2025

View reviewed changes

samfreund reviewed Dec 26, 2025

View reviewed changes

photon-core/src/main/java/org/photonvision/common/hardware/metrics/DeviceMetrics.java Show resolved Hide resolved

crschardt added 5 commits December 28, 2025 21:32

add disk space metrics, refactor network traffic, add comments, and c…

5ce9f83

…lean up.

Refactor and document thermal zones for temperature monitoring

f0b240e

Add subclass for RubikPi3

bfc4901

wpiformat doesn't like the blank line

cd75121

missed renaming sent and recv in NetworkTables

6b4ca07

crschardt added 2 commits December 31, 2025 23:01

remove metric update button and replace with last updated text

93bb733

Remove MetricsManager and clean up

c474cea

crschardt requested a review from a team as a code owner January 1, 2026 18:16

crschardt added 3 commits January 1, 2026 12:23

minor fixes

d236201

update tests

a1f8a8c

Remove test for MetricsManager

855bf79

samfreund previously approved these changes Jan 1, 2026

View reviewed changes

Gold856 requested changes Jan 1, 2026

View reviewed changes

monospace metrics

1af6f1c

samfreund dismissed their stale review via 1af6f1c January 1, 2026 21:05

crschardt enabled auto-merge (squash) January 1, 2026 21:07

Gold856 disabled auto-merge January 1, 2026 21:09

crschardt added 3 commits January 1, 2026 15:41

addressed comments

6ca13bd

Merge branch 'feat/oshi-metrics-manager' of https://github.com/crscha…

b1baaf3

…rdt/photonvision into feat/oshi-metrics-manager

monospace update time also

33ef9a3

Gold856 requested changes Jan 1, 2026

View reviewed changes

photon-client/src/stores/settings/GeneralSettingsStore.ts Outdated Show resolved Hide resolved

crschardt added 6 commits January 1, 2026 18:28

addressing comments

b3106f4

spotless

fdf9a7d

frontend cleanup

85b3507

Merge remote-tracking branch 'upstream/main' into feat/oshi-metrics-m…

7ca8976

…anager

a few comment fixes

bfee10b

Merge remote-tracking branch 'upstream/main' into feat/oshi-metrics-m…

4374d8b

…anager

crschardt requested a review from Gold856 January 2, 2026 22:03

Gold856 reviewed Jan 2, 2026

View reviewed changes

photon-core/src/main/java/org/photonvision/common/hardware/metrics/cmds/QCS6490Cmds.java Show resolved Hide resolved

Gold856 linked an issue Jan 2, 2026 that may be closed by this pull request

NpuUsageCommand is not included in the hardware config #1993

Closed

Gold856 approved these changes Jan 2, 2026

View reviewed changes

Gold856 merged commit 5409573 into PhotonVision:main Jan 2, 2026
70 of 80 checks passed

crschardt deleted the feat/oshi-metrics-manager branch January 3, 2026 04:27

samfreund mentioned this pull request Jan 3, 2026

Use an enum for the metrics cmds #1996

Closed

crschardt mentioned this pull request Jan 30, 2026

Remove unused commands from the custom hardware configuration documentation #2343

Merged

7 tasks

Conversation

crschardt commented Dec 24, 2025 • edited by Gold856 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Meta

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

samfreund commented Dec 31, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

crschardt commented Dec 24, 2025 •

edited by Gold856

Loading