Skip to content

Fix client linting in CI#2167

Merged
samfreund merged 2 commits intoPhotonVision:mainfrom
samfreund:fix-client-linting
Oct 30, 2025
Merged

Fix client linting in CI#2167
samfreund merged 2 commits intoPhotonVision:mainfrom
samfreund:fix-client-linting

Conversation

@samfreund
Copy link
Member

@samfreund samfreund commented Oct 30, 2025

Description

When running the CI check for client linting, we were running eslint with --fix. This means we're fixing problems, then throwing an error if any problems remain. We want to throw an error if any problems exist, and not fix them, since that can't get committed.

Meta

Merge checklist:

  • Pull Request title is short, imperative summary of proposed changes
  • The description documents the what and why
  • If this PR changes behavior or adds a feature, user documentation is updated
  • If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly
  • If this PR touches configuration, this is backwards compatible with settings back to v2025.3.2
  • If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated
  • If this PR addresses a bug, a regression test for it is added

@samfreund samfreund requested a review from a team as a code owner October 30, 2025 17:33
@github-actions github-actions bot added the frontend Having to do with PhotonClient and its related items label Oct 30, 2025
@samfreund samfreund enabled auto-merge (squash) October 30, 2025 20:59
@samfreund samfreund disabled auto-merge October 30, 2025 23:52
@samfreund samfreund merged commit 5d39ef5 into PhotonVision:main Oct 30, 2025
41 checks passed
@samfreund samfreund deleted the fix-client-linting branch October 30, 2025 23:52
spacey-sooty pushed a commit to spacey-sooty/photonvision that referenced this pull request Dec 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend Having to do with PhotonClient and its related items

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants