Fix calibration resolution default bug#2156
Merged
samfreund merged 2 commits intoPhotonVision:mainfrom Oct 24, 2025
Merged
Conversation
94e9aae to
1ba2578
Compare
Member
|
I get 1920x1080 defaulted on page reload despite the fact that it's not an option. Otherwise, it's blank. This is with a camera with no video modes. |
Member
|
What's the default resolution supposed to be? |
Member
Author
Whatever the camera's current resolution is |
Member
|
Placeholder Camera has nothing selected by default now, which feels odd. |
6d5d724 to
1ba2578
Compare
Gold856
approved these changes
Oct 24, 2025
spacey-sooty
pushed a commit
to spacey-sooty/photonvision
that referenced
this pull request
Dec 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
During the move to Vue 3 (see #1900), the default calibration for resolution wasn't properly set. This fixes the issue.
closes #2145
Meta
Merge checklist: