Skip to content

Modify build-image to use global variable for image version#2111

Merged
samfreund merged 2 commits intoPhotonVision:test-ci-varsfrom
samfreund:env-versioning-build
Oct 9, 2025
Merged

Modify build-image to use global variable for image version#2111
samfreund merged 2 commits intoPhotonVision:test-ci-varsfrom
samfreund:env-versioning-build

Conversation

@samfreund
Copy link
Copy Markdown
Member

Description

I added a global variable under settings, this variable controls the version of the image that is pulled down from https://github.com/PhotonVision/photon-image-modifier.

Meta

Merge checklist:

  • Pull Request title is short, imperative summary of proposed changes
  • The description documents the what and why
  • If this PR changes behavior or adds a feature, user documentation is updated
  • If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly
  • If this PR touches configuration, this is backwards compatible with settings back to v2025.3.2
  • If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated
  • If this PR addresses a bug, a regression test for it is added

@samfreund samfreund requested a review from a team as a code owner October 8, 2025 23:02
@samfreund
Copy link
Copy Markdown
Member Author

This overlaps with #2110, if that gets merged first this will need modification to follow.

Copy link
Copy Markdown
Contributor

@mcm001 mcm001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This forces us to put all the images on the same pin. Do we want that? I assume yes?

@samfreund
Copy link
Copy Markdown
Member Author

This forces us to put all the images on the same pin. Do we want that? I assume yes?

Ye, that's kinda the point. If there's an image in a release that's bad, we should cut a new one. If there's a new image we want to use, we should also cut a new one.

@samfreund samfreund force-pushed the env-versioning-build branch from 3f7ab77 to 468ba92 Compare October 9, 2025 01:05
@samfreund
Copy link
Copy Markdown
Member Author

@mcm001 so we can't reference variables on PRs from outside the repo. That's fine, cause we only run these jobs inside the repo. I believe the current config ought to work, but we can also create a branch inside the repo to test if we want.

@samfreund samfreund changed the base branch from main to test-ci-vars October 9, 2025 01:20
@samfreund samfreund force-pushed the env-versioning-build branch from 3acc142 to 67d6bd4 Compare October 9, 2025 01:21
@samfreund samfreund merged commit 1cc25a8 into PhotonVision:test-ci-vars Oct 9, 2025
48 of 61 checks passed
@samfreund samfreund deleted the env-versioning-build branch October 9, 2025 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants