Modify build-image to use global variable for image version#2111
Merged
samfreund merged 2 commits intoPhotonVision:test-ci-varsfrom Oct 9, 2025
Merged
Modify build-image to use global variable for image version#2111samfreund merged 2 commits intoPhotonVision:test-ci-varsfrom
samfreund merged 2 commits intoPhotonVision:test-ci-varsfrom
Conversation
7 tasks
Member
Author
|
This overlaps with #2110, if that gets merged first this will need modification to follow. |
samfreund
commented
Oct 8, 2025
mcm001
reviewed
Oct 8, 2025
Contributor
mcm001
left a comment
There was a problem hiding this comment.
This forces us to put all the images on the same pin. Do we want that? I assume yes?
Member
Author
Ye, that's kinda the point. If there's an image in a release that's bad, we should cut a new one. If there's a new image we want to use, we should also cut a new one. |
3f7ab77 to
468ba92
Compare
Member
Author
|
@mcm001 so we can't reference variables on PRs from outside the repo. That's fine, cause we only run these jobs inside the repo. I believe the current config ought to work, but we can also create a branch inside the repo to test if we want. |
3acc142 to
67d6bd4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I added a global variable under settings, this variable controls the version of the image that is pulled down from https://github.com/PhotonVision/photon-image-modifier.
Meta
Merge checklist: