Properly declare inputs and output for buildClient#2086
Merged
samfreund merged 7 commits intoPhotonVision:mainfrom Sep 16, 2025
Merged
Properly declare inputs and output for buildClient#2086samfreund merged 7 commits intoPhotonVision:mainfrom
samfreund merged 7 commits intoPhotonVision:mainfrom
Conversation
Member
Author
|
Needs testing. Also, since you don't to run the task separately anymore, should we remove https://docs.photonvision.org/en/v2025.3.2/docs/contributing/building-photon.html#build-and-copy-ui-to-java-source? |
samfreund
previously approved these changes
Sep 12, 2025
eb47e5c to
588d016
Compare
588d016 to
1dc24e8
Compare
83c95e2 to
9d87394
Compare
Member
|
LGTM, lemme remove reqs for those checks and do another test. Then I'll merge it. |
samfreund
approved these changes
Sep 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This allows Gradle to skip building the UI if none of the files in photon-client changed, which allows us to make the JAR task depend on the UI build task without wasting time rebuilding unnecessarily, which means building the UI no longer needs to be a separate step.
Fixes #2085.
Meta
Merge checklist: