Skip to content

Exclude license from being loaded as a model#2063

Merged
samfreund merged 2 commits intoPhotonVision:mainfrom
samfreund:license-model-exclusion
Aug 15, 2025
Merged

Exclude license from being loaded as a model#2063
samfreund merged 2 commits intoPhotonVision:mainfrom
samfreund:license-model-exclusion

Conversation

@samfreund
Copy link
Member

@samfreund samfreund commented Aug 13, 2025 •
edited
Loading

Description

image

Meta

Merge checklist:

  • Pull Request title is short, imperative summary of proposed changes
  • The description documents the what and why
  • If this PR changes behavior or adds a feature, user documentation is updated
  • If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly
  • If this PR touches configuration, this is backwards compatible with settings back to v2024.3.1
  • If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated
  • If this PR addresses a bug, a regression test for it is added

@samfreund samfreund requested a review from a team as a code owner August 13, 2025 23:28
@github-actions github-actions bot added the backend Things relating to photon-core and photon-server label Aug 13, 2025
@samfreund
Copy link
Member Author

samfreund commented Aug 13, 2025

I tested, and it works. Don't take my word for it tho, test it yourself!

@samfreund samfreund added bug Something isn't working and removed bug Something isn't working labels Aug 13, 2025
Gold856
Gold856 previously requested changes Aug 14, 2025
View reviewed changes
@samfreund samfreund force-pushed the license-model-exclusion branch from c61b644 to 63f8357 Compare August 15, 2025 02:36
@samfreund samfreund requested review from Gold856 and mcm001 August 15, 2025 02:36
mcm001
mcm001 previously approved these changes Aug 15, 2025
View reviewed changes
@samfreund samfreund force-pushed the license-model-exclusion branch from 63f8357 to c33a2c2 Compare August 15, 2025 02:45
@github-actions github-actions bot removed the backend Things relating to photon-core and photon-server label Aug 15, 2025
@samfreund samfreund force-pushed the license-model-exclusion branch from c33a2c2 to 56eaa76 Compare August 15, 2025 02:46
@samfreund samfreund requested a review from mcm001 August 15, 2025 02:46
@github-actions github-actions bot added the backend Things relating to photon-core and photon-server label Aug 15, 2025
@samfreund samfreund force-pushed the license-model-exclusion branch from 0551229 to 74f8ee5 Compare August 15, 2025 02:48
mcm001
mcm001 approved these changes Aug 15, 2025
View reviewed changes
Copy link
Contributor

@mcm001 mcm001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't have test hardware but lgtm

@samfreund samfreund enabled auto-merge (squash) August 15, 2025 20:17
@samfreund samfreund merged commit c7f5edc into PhotonVision:main Aug 15, 2025
42 checks passed
@samfreund samfreund deleted the license-model-exclusion branch August 15, 2025 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcm001 mcm001 mcm001 approved these changes

@Gold856 Gold856 Awaiting requested review from Gold856

Assignees

No one assigned

Labels

backend Things relating to photon-core and photon-server

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@samfreund @mcm001 @Gold856