Preload OD models before import to check quantization#2056
Merged
samfreund merged 16 commits intoPhotonVision:mainfrom Aug 16, 2025
Merged
Preload OD models before import to check quantization#2056samfreund merged 16 commits intoPhotonVision:mainfrom
samfreund merged 16 commits intoPhotonVision:mainfrom
Conversation
github-actions
bot
added
the
backend
mcm001
reviewed
Aug 11, 2025
photon-core/src/main/java/org/photonvision/vision/objects/RubikObjectDetector.java
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
samfreund
force-pushed
the
check-model-quant
branch
from
1639334 to
38b307f
Compare
samfreund
requested changes
Aug 14, 2025
…into check-model-quant
…into check-model-quant
Member
|
Can we adjust the description so it reflects what we're currently doing? |
samfreund
previously approved these changes
Aug 14, 2025
boomermath
changed the title
samfreund
previously approved these changes
Aug 15, 2025
samfreund
previously approved these changes
Aug 16, 2025
samfreund
force-pushed
the
check-model-quant
branch
from
2905a68 to
eb90963
Compare
samfreund
approved these changes
Aug 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Preloads a model to check for successful loading and quantization before importing it into PV.
Meta
Merge checklist: