Skip to content

Remove log spam from periodic network and IP address queries#2051

Merged
mcm001 merged 6 commits intoPhotonVision:mainfrom
crschardt:crschardt/issue2050
Aug 10, 2025
Merged

Remove log spam from periodic network and IP address queries#2051
mcm001 merged 6 commits intoPhotonVision:mainfrom
crschardt:crschardt/issue2050

Conversation

@crschardt
Copy link
Contributor

Fixes #2050

@crschardt crschardt requested a review from a team as a code owner August 9, 2025 19:39
@github-actions github-actions bot added the backend Things relating to photon-core and photon-server label Aug 9, 2025
samfreund
samfreund previously approved these changes Aug 9, 2025
@Gold856
Copy link
Member

Gold856 commented Aug 9, 2025

Do we also want to expand the scope of this to remove the Publishing Metrics spam?

@crschardt
Copy link
Contributor Author

Do we also want to expand the scope of this to remove the Publishing Metrics spam?

That makes sense to me. That line isn't particularly useful.

Gold856
Gold856 previously approved these changes Aug 9, 2025
Copy link
Contributor

@mcm001 mcm001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't seem like these debug messages were ever helpful anyway anyways, right? No reason to ever want to turn them back on?

@crschardt
Copy link
Contributor Author

It doesn't seem like these debug messages were ever helpful anyway anyways, right? No reason to ever want to turn them back on?

I don’t think they help. The method that was logging network interfaces used to be called only when a change was detected on the network. With the recent code changes, it’s now being called every 10 seconds, and that leads to a lot of boring entries. It should now only log on a change to network devices.

I should investigate if this actually needs to be called so often, since the network interfaces really really shouldn’t change. It might be better to call this at boot and return a cached value after that.

@mcm001 mcm001 merged commit 29e1836 into PhotonVision:main Aug 10, 2025
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend Things relating to photon-core and photon-server

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove log spam from periodic network and IP address queries

4 participants