Skip to content

Make dashboard theme transition smooth and fix link color#2046

Merged
mcm001 merged 1 commit intoPhotonVision:mainfrom
Gold856:fix-theme-transition-and-link-color
Aug 8, 2025
Merged

Make dashboard theme transition smooth and fix link color#2046
mcm001 merged 1 commit intoPhotonVision:mainfrom
Gold856:fix-theme-transition-and-link-color

Conversation

@Gold856
Copy link
Copy Markdown
Member

@Gold856 Gold856 commented Aug 8, 2025

Description

Poking around in DevTools allowed me to find the CSS class needed to apply the theme transition to the dashboard tabs. Now the dashboard tabs transition smoothly with the rest of the card when the theme changes. Also changed the link color to be yellow, which looks much nicer than before.

Old:
image

New:
image

Meta

Merge checklist:

  • Pull Request title is short, imperative summary of proposed changes
  • The description documents the what and why
  • If this PR changes behavior or adds a feature, user documentation is updated
  • If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly
  • If this PR touches configuration, this is backwards compatible with settings back to v2024.3.1
  • If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated
  • If this PR addresses a bug, a regression test for it is added

@Gold856 Gold856 requested a review from a team as a code owner August 8, 2025 06:08
@Gold856 Gold856 changed the title Make dashboard theme transition smooth and fix link color in alert Make dashboard theme transition smooth and fix link color Aug 8, 2025
@github-actions github-actions bot added the frontend Having to do with PhotonClient and its related items label Aug 8, 2025
@Gold856 Gold856 added the styling Issue pertaining to styling issues in the PhotonClient label Aug 8, 2025
@Gold856 Gold856 force-pushed the fix-theme-transition-and-link-color branch from 1663c70 to 5a1d7e8 Compare August 8, 2025 06:29
Copy link
Copy Markdown
Contributor

@mcm001 mcm001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prettttyyyyyy

@mcm001 mcm001 merged commit e23df8c into PhotonVision:main Aug 8, 2025
43 checks passed
@Gold856 Gold856 deleted the fix-theme-transition-and-link-color branch August 8, 2025 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend Having to do with PhotonClient and its related items styling Issue pertaining to styling issues in the PhotonClient

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants